content/browser/device_orientation/data_fetcher_shared_memory_base.h - Issue 22926029: Mac: implement orientation/motion shared memory data fetcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_orientation/data_fetcher_shared_memory_base.h

Issue 22926029: Mac: implement orientation/motion shared memory data fetcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/device_orientation/data_fetcher_shared_memory.h ('K') | « content/browser/device_orientation/data_fetcher_shared_memory.h ('k') | content/browser/device_orientation/data_fetcher_shared_memory_base.cc » ('j') | content/browser/device_orientation/data_fetcher_shared_memory_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_orientation/data_fetcher_shared_memory_base.h

diff --git a/content/browser/device_orientation/data_fetcher_shared_memory_base.h b/content/browser/device_orientation/data_fetcher_shared_memory_base.h

index a44959601ace325619349d349483c61297af6903..03d3100b84732c838a512867e9080f03599b4116 100644

--- a/content/browser/device_orientation/data_fetcher_shared_memory_base.h

+++ b/content/browser/device_orientation/data_fetcher_shared_memory_base.h

@@ -59,8 +59,9 @@ class CONTENT_EXPORT DataFetcherSharedMemoryBase {

// fetch the sensor data.

virtual bool IsPolling() const;

- // Start() method should call InitSharedMemoryBuffer() and cache the obtained

- // pointer for efficienty and thread-safety.

+ // Start() method should call InitSharedMemoryBuffer() to get the shared

bulach 2013/08/23 16:03:34 nit: s/shared shared/shared/ :)

timvolodine 2013/08/23 16:34:55 Done.

+ // shared memory pointer. If IsPolling() is true both Start() and Stop()

+ // methods are called from the |polling_thread_|.

virtual bool Start(ConsumerType consumer_type) = 0;

virtual bool Stop(ConsumerType consumer_type) = 0;