Mac: implement orientation/motion shared memory data fetcher.

Mac: implement orientation/motion shared memory data fetcher.

Add Device Motion/Orientation data fetcher for the mac platform. The fetcher uses the mac's sudden motion sensor to obtain acceleration and orientation information. It uses a polling thread to update shared memory at regular intervals. This patch also contains some minor changes to the base polling thread implementation to make the fetcher thread safe.

also fixes a leak in a test, see crbug.com/280129.

BUG=261165, 280129
NOTRY=true
R=bulach@chromium.org, piman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219861

[bulach, 2013-08-23 16:03:34]

lgtm once the bots are happy, thanks tim!

some suggestions below:

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
File content/browser/device_orientation/data_fetcher_shared_memory.h (right):

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
content/browser/device_orientation/data_fetcher_shared_memory.h:14: class
SuddenMotionSensor;
scoped_ptr requires the #include to be in rather than just a fwd declaration.

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
File content/browser/device_orientation/data_fetcher_shared_memory_base.h
(right):

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
content/browser/device_orientation/data_fetcher_shared_memory_base.h:62: //
Start() method should call InitSharedMemoryBuffer() to get the shared
nit: s/shared shared/shared/ :)

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
File content/browser/device_orientation/data_fetcher_shared_memory_mac.cc
(right):

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
content/browser/device_orientation/data_fetcher_shared_memory_mac.cc:65: // See
crbug.com/136010.
is it still relevant?

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
content/browser/device_orientation/data_fetcher_shared_memory_mac.cc:90: }
nit:  // namespace

[timvolodine, 2013-08-23 16:34:55]

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
File content/browser/device_orientation/data_fetcher_shared_memory.h (right):

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
content/browser/device_orientation/data_fetcher_shared_memory.h:14: class
SuddenMotionSensor;
On 2013/08/23 16:03:34, bulach wrote:
> scoped_ptr requires the #include to be in rather than just a fwd declaration.

not true. scoped_ptr appears to work ok with fwd decl.

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
File content/browser/device_orientation/data_fetcher_shared_memory_base.h
(right):

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
content/browser/device_orientation/data_fetcher_shared_memory_base.h:62: //
Start() method should call InitSharedMemoryBuffer() to get the shared
On 2013/08/23 16:03:34, bulach wrote:
> nit: s/shared shared/shared/ :)

Done.

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
File content/browser/device_orientation/data_fetcher_shared_memory_mac.cc
(right):

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
content/browser/device_orientation/data_fetcher_shared_memory_mac.cc:65: // See
crbug.com/136010.
On 2013/08/23 16:03:34, bulach wrote:
> is it still relevant?

hmm yes, will need to figure that one out still..

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
content/browser/device_orientation/data_fetcher_shared_memory_mac.cc:90: }
On 2013/08/23 16:03:34, bulach wrote:
> nit:  // namespace

Done.

[bulach, 2013-08-23 16:37:36]

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
File content/browser/device_orientation/data_fetcher_shared_memory.h (right):

https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
content/browser/device_orientation/data_fetcher_shared_memory.h:14: class
SuddenMotionSensor;
On 2013/08/23 16:34:55, timvolodine wrote:
> On 2013/08/23 16:03:34, bulach wrote:
> > scoped_ptr requires the #include to be in rather than just a fwd
declaration.
> 
> not true. scoped_ptr appears to work ok with fwd decl.

ops, sorry, you're right :)
it needs the #include _only_ if the destructor is inline, which is not the case
here..

[timvolodine, 2013-08-23 17:03:55]

On 2013/08/23 16:37:36, bulach wrote:
>
https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
> File content/browser/device_orientation/data_fetcher_shared_memory.h (right):
> 
>
https://codereview.chromium.org/22926029/diff/1/content/browser/device_orient...
> content/browser/device_orientation/data_fetcher_shared_memory.h:14: class
> SuddenMotionSensor;
> On 2013/08/23 16:34:55, timvolodine wrote:
> > On 2013/08/23 16:03:34, bulach wrote:
> > > scoped_ptr requires the #include to be in rather than just a fwd
> declaration.
> > 
> > not true. scoped_ptr appears to work ok with fwd decl.
> 
> ops, sorry, you're right :)
> it needs the #include _only_ if the destructor is inline, which is not the
case
> here..

ah ok I see. thanks! :)

[commit-bot: I haz the power, 2013-08-27 11:15:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/22926029/19001

[timvolodine, 2013-08-27 12:20:15]

+ piman@
for content/content_browser.gypi

[commit-bot: I haz the power, 2013-08-27 13:20:32]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[piman, 2013-08-27 17:24:22]

lgtm

[Nico, 2013-08-27 18:36:34]

Say "also fixes a leak in a test" to the cl description.

https://codereview.chromium.org/22926029/diff/33001/content/browser/device_or...
File
content/browser/device_orientation/data_fetcher_shared_memory_base_unittest.cc
(right):

https://codereview.chromium.org/22926029/diff/33001/content/browser/device_or...
content/browser/device_orientation/data_fetcher_shared_memory_base_unittest.cc:184:
scoped_ptr<FakeNonPollingDataFetcher> mock_data_fetcher(
Does this have to live on the heap? Why not just 

  FakeNonPollingDataFetcher mock_data_fetcher;

?

[Nico, 2013-08-27 18:44:10]

On 2013/08/27 18:36:34, Nico wrote:
> Say "also fixes a leak in a test" to the cl description.

Err, "in", not "to" :-D

> 
>
https://codereview.chromium.org/22926029/diff/33001/content/browser/device_or...
> File
> content/browser/device_orientation/data_fetcher_shared_memory_base_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/22926029/diff/33001/content/browser/device_or...
>
content/browser/device_orientation/data_fetcher_shared_memory_base_unittest.cc:184:
> scoped_ptr<FakeNonPollingDataFetcher> mock_data_fetcher(
> Does this have to live on the heap? Why not just 
> 
>   FakeNonPollingDataFetcher mock_data_fetcher;
> 
> ?

[timvolodine, 2013-08-27 18:54:29]

I tried talking to it -- didn't really help ;)

https://codereview.chromium.org/22926029/diff/33001/content/browser/device_or...
File
content/browser/device_orientation/data_fetcher_shared_memory_base_unittest.cc
(right):

https://codereview.chromium.org/22926029/diff/33001/content/browser/device_or...
content/browser/device_orientation/data_fetcher_shared_memory_base_unittest.cc:184:
scoped_ptr<FakeNonPollingDataFetcher> mock_data_fetcher(
On 2013/08/27 18:36:34, Nico wrote:
> Does this have to live on the heap? Why not just 
> 
>   FakeNonPollingDataFetcher mock_data_fetcher;
> 
> ?

Done.

[Nico, 2013-08-27 18:57:55]

On 2013/08/27 18:54:29, timvolodine wrote:
> I tried talking to it -- didn't really help ;)
> 
>
https://codereview.chromium.org/22926029/diff/33001/content/browser/device_or...
> File
> content/browser/device_orientation/data_fetcher_shared_memory_base_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/22926029/diff/33001/content/browser/device_or...
>
content/browser/device_orientation/data_fetcher_shared_memory_base_unittest.cc:184:
> scoped_ptr<FakeNonPollingDataFetcher> mock_data_fetcher(
> On 2013/08/27 18:36:34, Nico wrote:
> > Does this have to live on the heap? Why not just 
> > 
> >   FakeNonPollingDataFetcher mock_data_fetcher;
> > 
> > ?
> 
> Done.

Thanks! Let's cq+ this :-)

[commit-bot: I haz the power, 2013-08-27 19:48:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/22926029/43001

[Nico, 2013-08-27 23:56:06]

Committed patchset #5 manually as r219861 (presubmit successful).