Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1969)

Unified Diff: cc/trees/layer_tree_host_impl.h

Issue 22926024: cc: Control activation from the Scheduler (Closed) Base URL: http://git.chromium.org/chromium/src.git@schedOutputSurface4
Patch Set: BlockNotifyReadyToActivateForTesting Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.h
diff --git a/cc/trees/layer_tree_host_impl.h b/cc/trees/layer_tree_host_impl.h
index 31870ac48bd1e5e290fc620bbe1cf495903ec875..2ee5dbd13b91c839e7afe881a7754ccf5a11f73a 100644
--- a/cc/trees/layer_tree_host_impl.h
+++ b/cc/trees/layer_tree_host_impl.h
@@ -61,7 +61,7 @@ class LayerTreeHostImplClient {
virtual void OnSwapBuffersCompleteOnImplThread() = 0;
virtual void BeginFrameOnImplThread(const BeginFrameArgs& args) = 0;
virtual void OnCanDrawStateChanged(bool can_draw) = 0;
- virtual void OnHasPendingTreeStateChanged(bool has_pending_tree) = 0;
+ virtual void NotifyReadyToActivate() = 0;
virtual void SetNeedsRedrawOnImplThread() = 0;
virtual void SetNeedsRedrawRectOnImplThread(gfx::Rect damage_rect) = 0;
virtual void DidInitializeVisibleTileOnImplThread() = 0;
@@ -184,6 +184,11 @@ class CC_EXPORT LayerTreeHostImpl
// Evict all textures by enforcing a memory policy with an allocation of 0.
void EvictTexturesForTesting();
+ // When blocking, this prevents client_->NotifyReadyToActivate() from being
+ // called. When disabled, it calls client_->NotifyReadyToActivate()
+ // immediately if any notifications had been blocked while blocking.
+ void BlockNotifyReadyToActivateForTesting(bool block);
+
// RendererClient implementation
virtual gfx::Rect DeviceViewport() const OVERRIDE;
private:
@@ -247,7 +252,7 @@ class CC_EXPORT LayerTreeHostImpl
const LayerTreeImpl* recycle_tree() const { return recycle_tree_.get(); }
virtual void CreatePendingTree();
void UpdateVisibleTiles();
- virtual void ActivatePendingTreeIfNeeded();
+ virtual void ActivatePendingTree();
// Shortcuts to layers on the active tree.
LayerImpl* RootLayer() const;
@@ -391,7 +396,6 @@ class CC_EXPORT LayerTreeHostImpl
LayerTreeHostImplClient* client,
Proxy* proxy,
RenderingStatsInstrumentation* rendering_stats_instrumentation);
- virtual void ActivatePendingTree();
// Virtual for testing.
virtual void AnimateLayers(base::TimeTicks monotonic_time,
@@ -471,7 +475,7 @@ class CC_EXPORT LayerTreeHostImpl
scoped_ptr<LayerTreeImpl> active_tree_;
// In impl-side painting mode, tree with possibly incomplete rasterized
- // content. May be promoted to active by ActivatePendingTreeIfNeeded().
+ // content. May be promoted to active by ActivatePendingTree().
scoped_ptr<LayerTreeImpl> pending_tree_;
// In impl-side painting mode, inert tree with layers that can be recycled
@@ -484,6 +488,8 @@ class CC_EXPORT LayerTreeHostImpl
bool wheel_scrolling_;
bool manage_tiles_needed_;
+ bool block_notify_ready_to_activate_for_testing_;
+ bool notify_ready_to_activate_was_blocked_;
// The optional delegate for the root layer scroll offset.
LayerScrollOffsetDelegate* root_layer_scroll_offset_delegate_;

Powered by Google App Engine
This is Rietveld 408576698