Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 2292583002: DevTools: Create 2D slider for shadow-editor offset (Closed)

Created:
4 years, 3 months ago by flandy
Modified:
4 years, 3 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Create 2D slider for shadow-editor offset This replaces the 1D sliders for X offset and Y offset. BUG=639095 Committed: https://crrev.com/3fdf53278760d3691bd7cb04203907f45475018d Cr-Commit-Position: refs/heads/master@{#415728}

Patch Set 1 #

Total comments: 18

Patch Set 2 : Address comments #

Total comments: 8

Patch Set 3 : Readdress comments #

Total comments: 4

Patch Set 4 : Move beginPath under if #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -46 lines) Patch
M third_party/WebKit/Source/devtools/front_end/common/Geometry.js View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js View 1 2 3 9 chunks +199 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/cssShadowEditor.css View 2 chunks +15 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/slider.css View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
flandy
Please take a look. See the bug for new screenshots.
4 years, 3 months ago (2016-08-29 17:28:52 UTC) #2
lushnikov
I played with the new control and liked it! I only miss "shift-drag" experience - ...
4 years, 3 months ago (2016-08-30 19:22:19 UTC) #3
flandy
Please take another look. > I played with the new control and liked it! I ...
4 years, 3 months ago (2016-08-30 22:50:42 UTC) #4
lushnikov
https://codereview.chromium.org/2292583002/diff/20001/third_party/WebKit/Source/devtools/front_end/common/Geometry.js File third_party/WebKit/Source/devtools/front_end/common/Geometry.js (right): https://codereview.chromium.org/2292583002/diff/20001/third_party/WebKit/Source/devtools/front_end/common/Geometry.js#newcode97 third_party/WebKit/Source/devtools/front_end/common/Geometry.js:97: this.x *= scalar; let's return a new object instead ...
4 years, 3 months ago (2016-08-31 00:48:03 UTC) #5
flandy
Please take another look. https://codereview.chromium.org/2292583002/diff/20001/third_party/WebKit/Source/devtools/front_end/common/Geometry.js File third_party/WebKit/Source/devtools/front_end/common/Geometry.js (right): https://codereview.chromium.org/2292583002/diff/20001/third_party/WebKit/Source/devtools/front_end/common/Geometry.js#newcode97 third_party/WebKit/Source/devtools/front_end/common/Geometry.js:97: this.x *= scalar; On 2016/08/31 ...
4 years, 3 months ago (2016-08-31 01:35:06 UTC) #6
lushnikov
https://codereview.chromium.org/2292583002/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js File third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js (right): https://codereview.chromium.org/2292583002/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js#newcode88 third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js:88: var slider = createSliderLabel(0, WebInspector.CSSShadowEditor.maxRange, -1); probably you wanted ...
4 years, 3 months ago (2016-08-31 15:46:33 UTC) #7
flandy
https://codereview.chromium.org/2292583002/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js File third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js (right): https://codereview.chromium.org/2292583002/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js#newcode88 third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js:88: var slider = createSliderLabel(0, WebInspector.CSSShadowEditor.maxRange, -1); On 2016/08/31 15:46:33, ...
4 years, 3 months ago (2016-08-31 16:31:27 UTC) #8
lushnikov
lgtm
4 years, 3 months ago (2016-08-31 17:47:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292583002/60001
4 years, 3 months ago (2016-08-31 18:11:21 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-31 19:56:36 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 19:58:25 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3fdf53278760d3691bd7cb04203907f45475018d
Cr-Commit-Position: refs/heads/master@{#415728}

Powered by Google App Engine
This is Rietveld 408576698