Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1520)

Issue 2292553003: Fix missing files found by gn gen --check. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix missing files found by gn gen --check. Move trace_events DEPS from v8/base/ to base/ Committed: https://pdfium.googlesource.com/pdfium/+/5fec597c1a23a87b30c6ee9a45534aee91278709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M BUILD.gn View 7 chunks +5 lines, -8 lines 0 comments Download
M DEPS View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Lei Zhang
The DEPS change makes gn gen --check happy, but adds pdfium/base, whereas before it was ...
4 years, 3 months ago (2016-08-30 05:55:00 UTC) #6
dsinclair
lgtm
4 years, 3 months ago (2016-08-30 13:39:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292553003/1
4 years, 3 months ago (2016-08-30 13:39:28 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 13:39:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/5fec597c1a23a87b30c6ee9a45534aee9127...

Powered by Google App Engine
This is Rietveld 408576698