Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22925003: Explain the reason why we don't have thread check in destructor of ByteStreamReader/WriterImpl (Closed)

Created:
7 years, 4 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, asanka, benjhayden+dwatch_chromium.org, jam
Visibility:
Public.

Description

Explain the reason why we don't have thread check in destructor of ByteStreamReader/Writer. They can be deleted before being used and it's safe to do so. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257173

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/browser/byte_stream.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tyoshino (SeeGerritForStatus)
7 years, 4 months ago (2013-08-16 11:04:43 UTC) #1
tyoshino (SeeGerritForStatus)
6 years, 9 months ago (2014-03-12 12:52:48 UTC) #2
jam
lgtm
6 years, 9 months ago (2014-03-13 16:39:53 UTC) #3
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 9 months ago (2014-03-14 04:14:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/22925003/4001
6 years, 9 months ago (2014-03-14 04:15:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 05:54:44 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=237935
6 years, 9 months ago (2014-03-14 05:54:45 UTC) #7
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 9 months ago (2014-03-14 07:25:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/22925003/4001
6 years, 9 months ago (2014-03-14 07:25:36 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 09:03:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-14 09:03:20 UTC) #11
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 9 months ago (2014-03-14 16:56:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/22925003/4001
6 years, 9 months ago (2014-03-14 16:56:51 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 19:14:48 UTC) #14
Message was sent while issue was closed. 
Change committed as 257173

Powered by Google App Engine
This is Rietveld 408576698