Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2292483003: [ios] Fixed kHtmlWithMultiplePasswordForms test case. (Closed)

Created:
4 years, 3 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 3 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fixed kHtmlWithMultiplePasswordForms test case. According to test comments the action should only differ by query and fragment, not by path. BUG=None Committed: https://crrev.com/4ff3b6810111fc4eb102332a715b23d590c901fc Cr-Commit-Position: refs/heads/master@{#415314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/browser/passwords/password_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Eugene But (OOO till 7-30)
I'm rewriting LoadHtml to feed HTML to web view instead of using data urls. As ...
4 years, 3 months ago (2016-08-30 00:50:05 UTC) #3
vabr (Chromium)
LGTM, I agree that the test using this HTML string looks like expecting no difference ...
4 years, 3 months ago (2016-08-30 08:16:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292483003/1
4 years, 3 months ago (2016-08-30 16:19:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 16:23:09 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 16:25:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ff3b6810111fc4eb102332a715b23d590c901fc
Cr-Commit-Position: refs/heads/master@{#415314}

Powered by Google App Engine
This is Rietveld 408576698