Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2292473004: Verify element exists before accessing. (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Verify element exists before accessing. Currently when the parser utility classes are outputting to a text buffer we do not verify that an element from an array exists before accessing. We can have null items in arrays (and dictionaries but the dictionary case is already handled). This Cl updates the code to check the element exists before attempting to use the element. BUG=chromium:641076 Committed: https://pdfium.googlesource.com/pdfium/+/c116e597ef4dfac88248d6de0e7c9bdf093b6e7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-08-29 19:34:51 UTC) #2
Wei Li
lgtm
4 years, 3 months ago (2016-08-29 19:47:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292473004/1
4 years, 3 months ago (2016-08-29 20:08:20 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 20:08:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/c116e597ef4dfac88248d6de0e7c9bdf093b...

Powered by Google App Engine
This is Rietveld 408576698