Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2292463002: [turbofan] Remove invalid typing rules. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove invalid typing rules. Drop the typing rules for the machine operators and replace them with UNREACHABLE. These typing rules were never correct and there's also no need to have those rules at all. Drive-by-fix: Remove the extremely annoying test-simplified-lowering.cc file, which is not very useful, but consumes a large amount of time to keep it compiling and passing. Instead we should introduce appropriate tests for the SimplifiedLowering that also test something meaningful w/o just cementing the implementation. R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/285e1e157a63c929cfb9d9466333c9798df6bb57 Cr-Commit-Position: refs/heads/master@{#38970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2361 lines) Patch
M src/compiler/typer.cc View 8 chunks +10 lines, -599 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +0 lines, -1756 lines 0 comments Download
M test/unittests/compiler/branch-elimination-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-29 08:58:04 UTC) #1
Benedikt Meurer
Hey Jaro, Dead code should be dead^WKill all the defensive programming. Please take a look. ...
4 years, 3 months ago (2016-08-29 08:58:36 UTC) #4
Jarin
lgtm
4 years, 3 months ago (2016-08-29 08:59:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292463002/1
4 years, 3 months ago (2016-08-29 09:00:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 09:20:03 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 09:20:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/285e1e157a63c929cfb9d9466333c9798df6bb57
Cr-Commit-Position: refs/heads/master@{#38970}

Powered by Google App Engine
This is Rietveld 408576698