Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: components/sync/syncable/directory_unittest.cc

Issue 2292393004: Remove stl_util from sync. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/syncable/directory_unittest.cc
diff --git a/components/sync/syncable/directory_unittest.cc b/components/sync/syncable/directory_unittest.cc
index eb3806ddeee8c5627bf24d4a3080067909a602f9..b33b267655c2abf120b9c7de93371f0d99dcabd7 100644
--- a/components/sync/syncable/directory_unittest.cc
+++ b/components/sync/syncable/directory_unittest.cc
@@ -10,6 +10,7 @@
#include <cstdlib>
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/rand_util.h"
#include "base/run_loop.h"
#include "base/strings/stringprintf.h"
@@ -294,8 +295,8 @@ TEST_F(SyncableDirectoryTest, TakeSnapshotGetsAllDirtyHandlesTest) {
// Make sure there's an entry for each new metahandle. Make sure all
// entries are marked dirty.
ASSERT_EQ(expected_dirty_metahandles.size(), snapshot.dirty_metas.size());
- for (EntryKernelSet::const_iterator i = snapshot.dirty_metas.begin();
- i != snapshot.dirty_metas.end(); ++i) {
+ for (auto i = snapshot.dirty_metas.begin(); i != snapshot.dirty_metas.end();
+ ++i) {
ASSERT_TRUE((*i)->is_dirty());
}
dir()->VacuumAfterSaveChanges(snapshot);
@@ -328,8 +329,8 @@ TEST_F(SyncableDirectoryTest, TakeSnapshotGetsAllDirtyHandlesTest) {
// Make sure there's an entry for each new metahandle. Make sure all
// entries are marked dirty.
EXPECT_EQ(expected_dirty_metahandles.size(), snapshot.dirty_metas.size());
- for (EntryKernelSet::const_iterator i = snapshot.dirty_metas.begin();
- i != snapshot.dirty_metas.end(); ++i) {
+ for (auto i = snapshot.dirty_metas.begin(); i != snapshot.dirty_metas.end();
+ ++i) {
EXPECT_TRUE((*i)->is_dirty());
}
dir()->VacuumAfterSaveChanges(snapshot);
@@ -418,8 +419,8 @@ TEST_F(SyncableDirectoryTest, TakeSnapshotGetsOnlyDirtyHandlesTest) {
// Make sure there's an entry for each changed metahandle. Make sure all
// entries are marked dirty.
EXPECT_EQ(number_changed, snapshot.dirty_metas.size());
- for (EntryKernelSet::const_iterator i = snapshot.dirty_metas.begin();
- i != snapshot.dirty_metas.end(); ++i) {
+ for (auto i = snapshot.dirty_metas.begin(); i != snapshot.dirty_metas.end();
+ ++i) {
EXPECT_TRUE((*i)->is_dirty());
}
dir()->VacuumAfterSaveChanges(snapshot);
@@ -2008,10 +2009,9 @@ TEST_F(SyncableDirectoryTest, MutableEntry_ImplicitParentId_Siblings) {
}
TEST_F(SyncableDirectoryTest, SaveChangesSnapshot_HasUnsavedMetahandleChanges) {
- EntryKernel kernel;
Directory::SaveChangesSnapshot snapshot;
EXPECT_FALSE(snapshot.HasUnsavedMetahandleChanges());
- snapshot.dirty_metas.insert(&kernel);
+ snapshot.dirty_metas.insert(base::MakeUnique<EntryKernel>());
EXPECT_TRUE(snapshot.HasUnsavedMetahandleChanges());
snapshot.dirty_metas.clear();
@@ -2021,7 +2021,7 @@ TEST_F(SyncableDirectoryTest, SaveChangesSnapshot_HasUnsavedMetahandleChanges) {
snapshot.metahandles_to_purge.clear();
EXPECT_FALSE(snapshot.HasUnsavedMetahandleChanges());
- snapshot.delete_journals.insert(&kernel);
+ snapshot.delete_journals.insert(base::MakeUnique<EntryKernel>());
EXPECT_TRUE(snapshot.HasUnsavedMetahandleChanges());
snapshot.delete_journals.clear();

Powered by Google App Engine
This is Rietveld 408576698