Remove stl_util from sync.

Remove stl_util from sync.

BUG=555865
Committed: https://crrev.com/528f6a93bae21ece4c51fddcb1bafc5af1a61a9d
Cr-Commit-Position: refs/heads/master@{#416434}

[Avi (use Gerrit), 2016-08-31 18:55:08]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 18:55:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 20:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 20:08:33]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-08-31 20:14:19]

avi@chromium.org changed reviewers:
+ zea@chromium.org

[Avi (use Gerrit), 2016-08-31 20:14:19]

I had to reverse-engineer ownership semantics and object flow from the code. Can
you please double-check all of that to ensure I got it all right?

https://codereview.chromium.org/2292393004/diff/1/components/sync/syncable/sy...
File components/sync/syncable/syncable_delete_journal.h (right):

https://codereview.chromium.org/2292393004/diff/1/components/sync/syncable/sy...
components/sync/syncable/syncable_delete_journal.h:33: typedef std::map<const
EntryKernel*, std::unique_ptr<EntryKernel>, LessByID>
Maybe this should be a map from ID to unique_ptr<EntryKernel> given how it's
used to look up entries by ID, but I don't know how unique IDs are.

[Avi (use Gerrit), 2016-09-01 18:05:31]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 18:05:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-09-01 18:17:07]

avi@chromium.org changed reviewers:
+ stanisc@chromium.org

[Avi (use Gerrit), 2016-09-01 18:17:07]

Nicolas is OOO. Stanislav, can you take a look?

Thanks!

[commit-bot: I haz the power, 2016-09-01 19:32:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 19:32:23]

Dry run: This issue passed the CQ dry run.

[pavely, 2016-09-01 20:59:18]

pavely@chromium.org changed reviewers:
+ pavely@chromium.org

[pavely, 2016-09-01 20:59:18]

lgtm

[maxbogue, 2016-09-01 21:10:21]

maxbogue@chromium.org changed reviewers:
+ maxbogue@chromium.org

[maxbogue, 2016-09-01 21:10:22]

https://codereview.chromium.org/2292393004/diff/20001/components/sync/syncabl...
File components/sync/syncable/directory.cc (right):

https://codereview.chromium.org/2292393004/diff/20001/components/sync/syncabl...
components/sync/syncable/directory.cc:193: delete_journal_ =
base::MakeUnique<DeleteJournal>(std::move(delete_journals));
I don't think you need the MakeUnique here, do you? This should be fine:

delete_journal_ = std::move(delete_journals);

[maxbogue, 2016-09-01 21:13:17]

https://codereview.chromium.org/2292393004/diff/20001/components/sync/syncabl...
File components/sync/syncable/directory.cc (right):

https://codereview.chromium.org/2292393004/diff/20001/components/sync/syncabl...
components/sync/syncable/directory.cc:193: delete_journal_ =
base::MakeUnique<DeleteJournal>(std::move(delete_journals));
On 2016/09/01 21:10:22, maxbogue wrote:
> I don't think you need the MakeUnique here, do you? This should be fine:
> 
> delete_journal_ = std::move(delete_journals);

Never mind, Pavel pointed out that these are different types, sorry!

[Avi (use Gerrit), 2016-09-01 21:46:23]

On 2016/09/01 21:13:17, maxbogue wrote:
>
https://codereview.chromium.org/2292393004/diff/20001/components/sync/syncabl...
> File components/sync/syncable/directory.cc (right):
> 
>
https://codereview.chromium.org/2292393004/diff/20001/components/sync/syncabl...
> components/sync/syncable/directory.cc:193: delete_journal_ =
> base::MakeUnique<DeleteJournal>(std::move(delete_journals));
> On 2016/09/01 21:10:22, maxbogue wrote:
> > I don't think you need the MakeUnique here, do you? This should be fine:
> > 
> > delete_journal_ = std::move(delete_journals);
> 
> Never mind, Pavel pointed out that these are different types, sorry!

Yep.

Two questions:
1. Did I get all the ownership right?
2. In syncable_delete_journal.h, can I make JournalIndex indexed by ID?

[Nicolas Zea, 2016-09-02 20:21:15]

I think theoretically it could be keyed by ID, but I think I prefer it this way.
ID is actually a string, and would take more space, and this also makes it
clearer that this is just a standin for a set. 

Given that, LGTM

[Avi (use Gerrit), 2016-09-03 02:04:03]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-09-03 02:04:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 03:09:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-03 03:13:27]

Description was changed from

==========
Remove stl_util from sync.

BUG=555865
==========

to

==========
Remove stl_util from sync.

BUG=555865

Committed: https://crrev.com/528f6a93bae21ece4c51fddcb1bafc5af1a61a9d
Cr-Commit-Position: refs/heads/master@{#416434}
==========

[commit-bot: I haz the power, 2016-09-03 03:13:28]

Patchset 2 (id:??) landed as
https://crrev.com/528f6a93bae21ece4c51fddcb1bafc5af1a61a9d
Cr-Commit-Position: refs/heads/master@{#416434}