Make CPDF_GraphState have a CPDF_GraphStateData instead of inheriting

Make CPDF_GraphState have a CPDF_GraphStateData instead of inheriting.

Get callers out of the copy-before-write business, and let the
class manage it instead.

Committed: https://pdfium.googlesource.com/pdfium/+/4d9df422c340b3bc33e044d3d94e1ff9582e1260

[Tom Sepez, 2016-08-30 21:33:11]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 21:33:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-30 21:35:08]

Description was changed from

==========
Make CPDF_GraphState have a CPDF_GraphStateData instead of inheriting
==========

to

==========
Make CPDF_GraphState have a CPDF_GraphStateData instead of inheriting.

Get callers out of the copy-before-write business, and let the
class manage it instead.
==========

[Tom Sepez, 2016-08-30 21:35:08]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-08-30 21:35:23]

Dan, for review.

[commit-bot: I haz the power, 2016-08-30 21:50:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 21:50:30]

Dry run: Try jobs failed on following builders:
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)

[Tom Sepez, 2016-08-30 22:05:05]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 22:05:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 22:32:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 22:32:22]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-08-31 13:42:25]

lgtm w/ nits.

https://codereview.chromium.org/2292363002/diff/20001/core/fpdfapi/fpdf_page/...
File core/fpdfapi/fpdf_page/cpdf_graphstate.cpp (right):

https://codereview.chromium.org/2292363002/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/cpdf_graphstate.cpp:12:
CPDF_GraphState::CPDF_GraphState(const CPDF_GraphState& that) {
nit: blank line before.

https://codereview.chromium.org/2292363002/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/cpdf_graphstate.cpp:13: m_Ref = that.m_Ref;
Initializer list?

[Tom Sepez, 2016-08-31 17:12:04]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 17:12:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 17:22:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 17:22:47]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-08-31 17:26:09]

https://codereview.chromium.org/2292363002/diff/20001/core/fpdfapi/fpdf_page/...
File core/fpdfapi/fpdf_page/cpdf_graphstate.cpp (right):

https://codereview.chromium.org/2292363002/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/cpdf_graphstate.cpp:12:
CPDF_GraphState::CPDF_GraphState(const CPDF_GraphState& that) {
On 2016/08/31 13:42:25, dsinclair wrote:
> nit: blank line before.

Done.

https://codereview.chromium.org/2292363002/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/cpdf_graphstate.cpp:13: m_Ref = that.m_Ref;
On 2016/08/31 13:42:25, dsinclair wrote:
> Initializer list?

Done.

[Tom Sepez, 2016-08-31 17:26:15]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-08-31 17:26:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2292363002/#ps40001
(title: "Rebase, nits")

[commit-bot: I haz the power, 2016-08-31 17:26:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 17:26:41]

Description was changed from

==========
Make CPDF_GraphState have a CPDF_GraphStateData instead of inheriting.

Get callers out of the copy-before-write business, and let the
class manage it instead.
==========

to

==========
Make CPDF_GraphState have a CPDF_GraphStateData instead of inheriting.

Get callers out of the copy-before-write business, and let the
class manage it instead.

Committed:
https://pdfium.googlesource.com/pdfium/+/4d9df422c340b3bc33e044d3d94e1ff9582e...
==========

[commit-bot: I haz the power, 2016-08-31 17:26:42]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/4d9df422c340b3bc33e044d3d94e1ff9582e...