Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2292353003: Cherry-pick r415013 to M53. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@gmail.com> 9 * Christian Biesinger <cbiesinger@gmail.com>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 1437 matching lines...) Expand 10 before | Expand all | Expand 10 after
1448 layer()->compositedLayerMapping()->setNeedsGraphicsLayerUpdate(Graph icsLayerUpdateSubtree); 1448 layer()->compositedLayerMapping()->setNeedsGraphicsLayerUpdate(Graph icsLayerUpdateSubtree);
1449 compositor->setNeedsCompositingUpdate(CompositingUpdateAfterGeometry Change); 1449 compositor->setNeedsCompositingUpdate(CompositingUpdateAfterGeometry Change);
1450 } else { 1450 } else {
1451 layer()->setNeedsCompositingInputsUpdate(); 1451 layer()->setNeedsCompositingInputsUpdate();
1452 } 1452 }
1453 } 1453 }
1454 } 1454 }
1455 1455
1456 bool PaintLayerScrollableArea::usesCompositedScrolling() const 1456 bool PaintLayerScrollableArea::usesCompositedScrolling() const
1457 { 1457 {
1458 // Scroll form controls on the main thread so they exhibit correct touch scr oll event bubbling
1459 if (box().isIntrinsicallyScrollable(VerticalScrollbar) || box().isIntrinsica llyScrollable(HorizontalScrollbar))
1460 return false;
1461
1462 // See https://codereview.chromium.org/176633003/ for the tests that fail wi thout this disabler. 1458 // See https://codereview.chromium.org/176633003/ for the tests that fail wi thout this disabler.
1463 DisableCompositingQueryAsserts disabler; 1459 DisableCompositingQueryAsserts disabler;
1464 return layer()->hasCompositedLayerMapping() && layer()->compositedLayerMappi ng()->scrollingLayer(); 1460 return layer()->hasCompositedLayerMapping() && layer()->compositedLayerMappi ng()->scrollingLayer();
1465 } 1461 }
1466 1462
1467 bool PaintLayerScrollableArea::shouldScrollOnMainThread() const 1463 bool PaintLayerScrollableArea::shouldScrollOnMainThread() const
1468 { 1464 {
1469 if (LocalFrame* frame = box().frame()) { 1465 if (LocalFrame* frame = box().frame()) {
1470 if (Page* page = frame->page()) { 1466 if (Page* page = frame->page()) {
1471 if (page->scrollingCoordinator()->shouldUpdateScrollLayerPositionOnM ainThread()) 1467 if (page->scrollingCoordinator()->shouldUpdateScrollLayerPositionOnM ainThread())
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
1748 1744
1749 void PaintLayerScrollableArea::DelayScrollPositionClampScope::clampScrollableAre as() 1745 void PaintLayerScrollableArea::DelayScrollPositionClampScope::clampScrollableAre as()
1750 { 1746 {
1751 for (auto& scrollableArea : *s_needsClamp) 1747 for (auto& scrollableArea : *s_needsClamp)
1752 scrollableArea->clampScrollPositionsAfterLayout(); 1748 scrollableArea->clampScrollPositionsAfterLayout();
1753 delete s_needsClamp; 1749 delete s_needsClamp;
1754 s_needsClamp = nullptr; 1750 s_needsClamp = nullptr;
1755 } 1751 }
1756 1752
1757 } // namespace blink 1753 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/paint/BlockPainter.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698