Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2292353002: Fix NFC crasher from accessing a destroyed activity. (Closed)

Created:
4 years, 3 months ago by Ted C
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix NFC crasher from accessing a destroyed activity. While this works, it would be better to have a clearer signal that the Activity died (or is in the process of shutting down) so we could make a better timed decision to disable NFC reading. Also note that Activity#isDestroyed() is only available in JELLY_BEAN_MR1, so this is not the best solution for all device implementations that need to determine this. BUG=640890 Committed: https://crrev.com/1ff2cc181eb07396527b76ba2e15d48684c27d15 Cr-Commit-Position: refs/heads/master@{#415441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M device/nfc/android/java/src/org/chromium/device/nfc/NfcImpl.java View 1 chunk +2 lines, -1 line 0 comments Download
M tools/android/eclipse/.classpath View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ted C
PTAL
4 years, 3 months ago (2016-08-30 20:48:40 UTC) #2
Reilly Grant (use Gerrit)
lgtm
4 years, 3 months ago (2016-08-30 20:51:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292353002/1
4 years, 3 months ago (2016-08-30 20:53:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 21:47:09 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:51:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ff2cc181eb07396527b76ba2e15d48684c27d15
Cr-Commit-Position: refs/heads/master@{#415441}

Powered by Google App Engine
This is Rietveld 408576698