blimp/client/app/android/java/src/org/chromium/blimp/input/ImeHelperDialog.java - Issue 2292343002: Hooking up Blimp IME with BlimpContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/app/android/java/src/org/chromium/blimp/input/ImeHelperDialog.java

Issue 2292343002: Hooking up Blimp IME with BlimpContents (Closed)

Patch Set: Addressed initial comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/app/android/ime_helper_dialog.cc ('K') | « blimp/client/app/android/ime_helper_dialog.cc ('k') | blimp/client/core/contents/BUILD.gn » ('j') | blimp/client/core/contents/android/ime_helper_dialog.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/app/android/java/src/org/chromium/blimp/input/ImeHelperDialog.java

diff --git a/blimp/client/app/android/java/src/org/chromium/blimp/input/ImeHelperDialog.java b/blimp/client/app/android/java/src/org/chromium/blimp/input/ImeHelperDialog.java

index 1b717d7be56531a5d7cd57a628ca0b9ba13173c8..2e0c396e610b44d0a1d9b2e88a8947d2badff90c 100644

--- a/blimp/client/app/android/java/src/org/chromium/blimp/input/ImeHelperDialog.java

+++ b/blimp/client/app/android/java/src/org/chromium/blimp/input/ImeHelperDialog.java

@@ -27,7 +27,7 @@ import org.chromium.ui.base.ime.TextInputType;

* A pop up is created when user taps on a text area prompting user to start typing and closes as

* soon as user hits enter or presses back button.

-@JNINamespace("blimp::client")

+@JNINamespace("blimp::client::app")

public class ImeHelperDialog {

private static final String TAG = "ImeHelperDialog";

private long mNativeImeHelperDialog;