Hooking up Blimp IME with BlimpContents

blimp/client/app/android/ime_helper_dialog.h

Index: blimp/client/app/android/ime_helper_dialog.h
diff --git a/blimp/client/app/android/ime_helper_dialog.h b/blimp/client/app/android/ime_helper_dialog.h
index ce419b928d782b954c350008abc7e5c0e201a16f..789c7d1635ac7ce756bc3224bfdf75d697c727bb 100644
--- a/blimp/client/app/android/ime_helper_dialog.h
+++ b/blimp/client/app/android/ime_helper_dialog.h
@@ -14,6 +14,7 @@
 
 namespace blimp {
 namespace client {
+namespace app {
 
 // The native component of org.chromium.blimp.input.ImeHelperDialog.
 class ImeHelperDialog : public ImeFeature::Delegate {

[David Trainor- moved to gerrit, 2016/08/31 05:59:09]

Do we need two versions of this class?  Are they diverging that much?

[shaktisahu, 2016/08/31 17:28:21]

Not a lot though. The app version is driven by Java and doesn't understand
WindowAndroid stuff. I have to make some changes to BlimpClientSession to make
the contents version work. I think we can delete this stuff shortly.

@@ -27,7 +28,8 @@ class ImeHelperDialog : public ImeFeature::Delegate {
 
   // Brings up IME for user to enter text.
   void OnShowImeRequested(ui::TextInputType input_type,
-                          const std::string& text) override;
+                          const std::string& text,
+                          const ShowImeCallback& callback) override;
 
   // Hides IME.
   void OnHideImeRequested() override;
@@ -50,9 +52,13 @@ class ImeHelperDialog : public ImeFeature::Delegate {
   // outgoing and incoming BlimpMessage::IME messages from the engine.
   ImeFeature* ime_feature_;
 
+  // A callback to be executed on text submission from the user.
+  ShowImeCallback textSubmitCallback_;

[David Trainor- moved to gerrit, 2016/08/31 05:59:09]

text_submit_callback_.  Could we also mention that it's the callback for the
current request?

[shaktisahu, 2016/08/31 17:28:21]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(ImeHelperDialog);
 };
 
+}  // namespace app
 }  // namespace client
 }  // namespace blimp