Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 2292343002: Hooking up Blimp IME with BlimpContents (Closed)
Patch Set: Addressed initial comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-z h-rCN/android_chrome_strings.xml" /> 249 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-z h-rCN/android_chrome_strings.xml" />
250 </issue> 250 </issue>
251 <issue id="UnusedResources"> 251 <issue id="UnusedResources">
252 <ignore regexp="android_ui_strings.xml" /> 252 <ignore regexp="android_ui_strings.xml" />
253 <ignore regexp="android_webview/tools/automated_ui_tests/java/res/" /> 253 <ignore regexp="android_webview/tools/automated_ui_tests/java/res/" />
254 <ignore regexp="blimp/client/app/android/java/res/layout/blimp_main.xml" /> 254 <ignore regexp="blimp/client/app/android/java/res/layout/blimp_main.xml" />
255 <ignore regexp="blimp/client/app/android/java/res/layout/text_input_popup.xm l" /> 255 <ignore regexp="blimp/client/app/android/java/res/layout/text_input_popup.xm l" />
256 <ignore regexp="blimp/client/app/android/java/res/layout/toolbar_popup_item. xml" /> 256 <ignore regexp="blimp/client/app/android/java/res/layout/toolbar_popup_item. xml" />
257 <ignore regexp="blimp/client/app/android/java/res/values/dimens.xml" /> 257 <ignore regexp="blimp/client/app/android/java/res/values/dimens.xml" />
258 <ignore regexp="blimp/client/app/android/java/res/xml/about_blimp_preference s.xml" /> 258 <ignore regexp="blimp/client/app/android/java/res/xml/about_blimp_preference s.xml" />
259 <ignore regexp="blimp/client/app/android/java/res/xml/blimp_preferences.xml" />
259 <!-- 260 <!--
260 This file isn't used if the target SDK version is less than 24. 261 This file isn't used if the target SDK version is less than 24.
261 TODO(estevenson) remove this and the conditional inclusion in 262 TODO(estevenson) remove this and the conditional inclusion in
262 AndroidManifest.xml after rolling to SDK 24. 263 AndroidManifest.xml after rolling to SDK 24.
263 --> 264 -->
264 <ignore regexp="chrome/android/java/res/xml/network_security_config.xml" /> 265 <ignore regexp="chrome/android/java/res/xml/network_security_config.xml" />
265 <ignore regexp="chrome/android/java/res/values/dimens.xml" /> 266 <ignore regexp="chrome/android/java/res/values/dimens.xml" />
266 <ignore regexp="chrome/android/java/res/values/ids.xml" /> 267 <ignore regexp="chrome/android/java/res/values/ids.xml" />
267 <ignore regexp="chrome/android/webapk/shell_apk/res/layout/main.xml" /> 268 <ignore regexp="chrome/android/webapk/shell_apk/res/layout/main.xml" />
268 <ignore regexp="chromecast/browser/android/apk/res/values/strings.xml" /> 269 <ignore regexp="chromecast/browser/android/apk/res/values/strings.xml" />
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 </issue> 303 </issue>
303 <issue id="ViewConstructor" severity="ignore" /> 304 <issue id="ViewConstructor" severity="ignore" />
304 <issue id="WrongCall" severity="ignore" /> 305 <issue id="WrongCall" severity="ignore" />
305 <issue id="WrongConstant"> 306 <issue id="WrongConstant">
306 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java" /> 307 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java" />
307 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java" /> 308 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java" />
308 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java" /> 309 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java" />
309 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java" /> 310 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java" />
310 </issue> 311 </issue>
311 </lint> 312 </lint>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698