Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: blimp/client/core/contents/blimp_contents_impl.h

Issue 2292343002: Hooking up Blimp IME with BlimpContents (Closed)
Patch Set: Addressed initial comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_CLIENT_CORE_CONTENTS_BLIMP_CONTENTS_IMPL_H_ 5 #ifndef BLIMP_CLIENT_CORE_CONTENTS_BLIMP_CONTENTS_IMPL_H_
6 #define BLIMP_CLIENT_CORE_CONTENTS_BLIMP_CONTENTS_IMPL_H_ 6 #define BLIMP_CLIENT_CORE_CONTENTS_BLIMP_CONTENTS_IMPL_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/observer_list.h" 9 #include "base/observer_list.h"
10 #include "blimp/client/core/contents/blimp_navigation_controller_delegate.h" 10 #include "blimp/client/core/contents/blimp_navigation_controller_delegate.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 // Handles the back/forward list and loading URLs. 68 // Handles the back/forward list and loading URLs.
69 BlimpNavigationControllerImpl navigation_controller_; 69 BlimpNavigationControllerImpl navigation_controller_;
70 70
71 // A list of all the observers of this BlimpContentsImpl. 71 // A list of all the observers of this BlimpContentsImpl.
72 base::ObserverList<BlimpContentsObserver> observers_; 72 base::ObserverList<BlimpContentsObserver> observers_;
73 73
74 // The id is assigned during contents creation. It is used by 74 // The id is assigned during contents creation. It is used by
75 // BlimpContentsManager to control the life time of the its observer. 75 // BlimpContentsManager to control the life time of the its observer.
76 int id_; 76 int id_;
77 77
78 // Handles the text input for web forms.
79 ImeFeature* ime_feature_;
80
78 // The tab control feature through which the BlimpContentsImpl is able to 81 // The tab control feature through which the BlimpContentsImpl is able to
79 // set size and scale. 82 // set size and scale.
80 // TODO(mlliu): in the long term, we want to put size and scale in a different 83 // TODO(mlliu): in the long term, we want to put size and scale in a different
81 // feature instead of tab control feature. crbug.com/639154. 84 // feature instead of tab control feature. crbug.com/639154.
82 TabControlFeature* tab_control_feature_ = nullptr; 85 TabControlFeature* tab_control_feature_ = nullptr;
83 86
84 // The BlimpContentsView abstracts the platform specific view system details 87 // The BlimpContentsView abstracts the platform specific view system details
85 // from the BlimpContents. 88 // from the BlimpContents.
86 std::unique_ptr<BlimpContentsView> blimp_contents_view_; 89 std::unique_ptr<BlimpContentsView> blimp_contents_view_;
87 90
88 DISALLOW_COPY_AND_ASSIGN(BlimpContentsImpl); 91 DISALLOW_COPY_AND_ASSIGN(BlimpContentsImpl);
89 }; 92 };
90 93
91 } // namespace client 94 } // namespace client
92 } // namespace blimp 95 } // namespace blimp
93 96
94 #endif // BLIMP_CLIENT_CORE_CONTENTS_BLIMP_CONTENTS_IMPL_H_ 97 #endif // BLIMP_CLIENT_CORE_CONTENTS_BLIMP_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698