Hooking up Blimp IME with BlimpContents

blimp/client/core/contents/blimp_contents_view_android.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/core/contents/blimp_contents_view_android.h"
 
 #include "base/memory/ptr_util.h"
 #include "blimp/client/core/contents/android/blimp_contents_impl_android.h"
+#include "blimp/client/core/contents/android/ime_helper_dialog.h"
 #include "cc/layers/layer.h"
 
 namespace blimp {
 namespace client {
 
 // static
 std::unique_ptr<BlimpContentsView> BlimpContentsView::Create(
     BlimpContentsImpl* blimp_contents) {
   return base::MakeUnique<BlimpContentsViewAndroid>(
       blimp_contents->GetBlimpContentsImplAndroid());
 }
 
 BlimpContentsViewAndroid::BlimpContentsViewAndroid(
     BlimpContentsImplAndroid* blimp_contents) {
   // TODO(khushalsagar): Get the ViewAndroidDelegate from java after it has a
   // BlimpView. Also get the WindowAndroid so this view can add itself as a
   // child to it.
   // TODO(dtrainor): Use the layer from the compositor manager here instead when
   // it goes in the BlimpContents.
   view_.SetLayer(cc::Layer::Create());
+  ime_dialog_.reset(new ImeHelperDialog(view_.GetWindowAndroid()));

[David Trainor- moved to gerrit, 2016/08/31 05:59:10]

Let's put this in the constructor, we can access the WindowAndroid from
blimp_contents->GetNativeWindow()

[shaktisahu, 2016/08/31 17:28:21]

I had to do
blimp_contents->blimp_contents_impl()->GetNativeView()->GetWindowAndroid()

[David Trainor- moved to gerrit, 2016/08/31 18:59:54]

Ah make the constructor take a BlimpClientsImpl() and not the Android version?

 }
 
+BlimpContentsViewAndroid::~BlimpContentsViewAndroid() {}

[David Trainor- moved to gerrit, 2016/08/31 05:59:10]

= default?

[shaktisahu, 2016/08/31 17:28:21]

Doesn't work. "Complex destructor has an inline body."
I guess the view_ has non-trivial destructor.

[shaktisahu, 2016/08/31 17:28:21]

Done.

[David Trainor- moved to gerrit, 2016/08/31 18:59:54]

= default; should be fine in the cc file though right?

+
 gfx::NativeView BlimpContentsViewAndroid::GetNativeView() {
   return &view_;
 }
 
+ImeFeature::Delegate* BlimpContentsViewAndroid::GetImeDelegate() {
+  return ime_dialog_.get();
+}
+
 }  // namespace client
 }  // namespace blimp