Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2292303004: SkPDF: Fix Type3 ToUnicode table. (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
Reviewers:
bungeman-skia, Rik
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: Fix Type3 ToUnicode table. This seems to fix text extraction on Adobe Reader - Registry/Ordering is now set to Skia/SkiaOrdering. - Type3 fonts now get a FontDescriptor (force symbolic font). - CMapName is now Skia-Identity-SkiaOrdering - CMap behaves correctly for single-byte fonts. Also: - SkTestTypeface returns tounicode map for testing. - Unit test updated All PDFs render the same BUG=skia:5606 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292303004 Committed: https://skia.googlesource.com/skia/+/3d01c62e19df9f369cdfaeff82ec8af2c0be75f1

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -32 lines) Patch
M src/fonts/SkTestScalerContext.cpp View 1 chunk +9 lines, -1 line 0 comments Download
M src/pdf/SkPDFFont.cpp View 5 chunks +16 lines, -5 lines 2 comments Download
M src/pdf/SkPDFMakeToUnicodeCmap.cpp View 9 chunks +28 lines, -23 lines 1 comment Download
M tests/PDFGlyphsToUnicodeTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
hal.canary
ptal
4 years, 3 months ago (2016-08-31 19:25:04 UTC) #5
bungeman-skia
lgtm
4 years, 3 months ago (2016-08-31 19:37:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292303004/1
4 years, 3 months ago (2016-08-31 19:38:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/3d01c62e19df9f369cdfaeff82ec8af2c0be75f1
4 years, 3 months ago (2016-08-31 19:52:39 UTC) #11
Rik
4 years, 3 months ago (2016-09-01 17:41:21 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/2292303004/diff/1/src/pdf/SkPDFFont.cpp
File src/pdf/SkPDFFont.cpp (right):

https://codereview.chromium.org/2292303004/diff/1/src/pdf/SkPDFFont.cpp#newco...
src/pdf/SkPDFFont.cpp:429: sysInfo->insertString("Registry", "Skia");
This change isn't needed

https://codereview.chromium.org/2292303004/diff/1/src/pdf/SkPDFFont.cpp#newco...
src/pdf/SkPDFFont.cpp:431: sysInfo->insertString("Ordering", "SkiaOrdering");
Neither is this one

https://codereview.chromium.org/2292303004/diff/1/src/pdf/SkPDFMakeToUnicodeC...
File src/pdf/SkPDFMakeToUnicodeCmap.cpp (right):

https://codereview.chromium.org/2292303004/diff/1/src/pdf/SkPDFMakeToUnicodeC...
src/pdf/SkPDFMakeToUnicodeCmap.cpp:29: "/Ordering (SkiaOrdering)\n"
Please leave this as-is

Powered by Google App Engine
This is Rietveld 408576698