Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: grit_info.py

Issue 22923027: Changes grit_info.py to respect target_platform when generating output lists. (Closed) Base URL: http://grit-i18n.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: grit_info.py
===================================================================
--- grit_info.py (revision 129)
+++ grit_info.py (working copy)
@@ -18,10 +18,10 @@
pass
-def Outputs(filename, defines, ids_file):
+def Outputs(filename, defines, ids_file, target_platform):
flackr 2013/09/05 18:47:15 Shouldn't we default target_platform=None since gr
Jói 2013/09/05 19:28:50 We should default it to target_platform=None, corr
grd = grd_reader.Parse(
filename, defines=defines, tags_to_ignore=set(['messages']),
- first_ids_file=ids_file)
+ first_ids_file=ids_file, target_platform=target_platform)
target = []
lang_folders = {}
@@ -155,7 +155,8 @@
prefix, filename = args
outputs = [posixpath.join(prefix, f)
- for f in Outputs(filename, defines, options.ids_file)]
+ for f in Outputs(filename, defines,
+ options.ids_file, options.target_platform)]
return '\n'.join(outputs)
else:
raise WrongNumberOfArguments("Expected --inputs or --outputs.")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698