Issue 22923027: Changes grit_info.py to respect target_platform when generating output lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22923027: Changes grit_info.py to respect target_platform when generating output lists. (Closed)

Created:
7 years, 4 months ago by rohitrao (ping after 24h)

Modified:
4 years, 10 months ago

Reviewers:
stuartmorgan, Jói

CC:
grit-developer_googlegroups.com, flackr

Base URL:
http://grit-i18n.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Changes grit_info.py to respect target_platform when generating output lists.

Patch Set 1 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	grit_info.py	View		2 chunks	+4 lines, -3 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

We need this in order to get the correct set of output files on iOS. ...

7 years, 4 months ago (2013-08-22 19:52:07 UTC) #1

flackr

https://codereview.chromium.org/22923027/diff/1/grit_info.py File grit_info.py (right): https://codereview.chromium.org/22923027/diff/1/grit_info.py#newcode21 grit_info.py:21: def Outputs(filename, defines, ids_file, target_platform): Shouldn't we default target_platform=None ...

7 years, 3 months ago (2013-09-05 18:47:15 UTC) #3

Jói

7 years, 3 months ago (2013-09-05 19:28:50 UTC) #4

https://codereview.chromium.org/22923027/diff/1/grit_info.py
File grit_info.py (right):

https://codereview.chromium.org/22923027/diff/1/grit_info.py#newcode21
grit_info.py:21: def Outputs(filename, defines, ids_file, target_platform):
On 2013/09/05 18:47:15, flackr wrote:
> Shouldn't we default target_platform=None since grd_reader has a default, and
we
> use this externally (See the attempted grit roll here:
> https://codereview.chromium.org/23658022/%29?

We should default it to target_platform=None, correct. It looks like in practice
that's what happens since the command-line parsing defaults this to None if not
set, but would be nicer to default the parameter to None as well.

Expand Messages | Collapse Messages