Make libnosys function stubs part of libnacl

src/untrusted/nacl/nacl.scons

 # -*- python -*-
 # Copyright (c) 2012 The Native Client Authors.  All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 Import('env')
 
 # NACL_GC_WRAP_SYSCALL uses ({...}) syntax.
 env.FilterOut(CCFLAGS=['-pedantic'])
@@ skipping 39 matching lines @@
     'read.c',
     'rmdir.c',
     'sbrk.c',
     'sched_yield.c',
     'stat.c',
     'sysconf.c',
     'unlink.c',
     'write.c',
 ]
 
+SRCS_NEWLIB_STUBS = [
+    'stubs/access-stub.c',
+    'stubs/chmod-stub.c',
+    'stubs/chown-stub.c',
+    'stubs/endpwent-stub.c',
+    'stubs/environ-stub.c',
+    'stubs/execle-stub.c',
+    'stubs/execvp-stub.c',
+    'stubs/execl-stub.c',
+    'stubs/execv-stub.c',
+    'stubs/execlp-stub.c',
+    'stubs/execve-stub.c',
+    'stubs/_execve-stub.c',
+    'stubs/fcntl-stub.c',
+    'stubs/fchdir-stub.c',
+    'stubs/fchmod-stub.c',
+    'stubs/fchown-stub.c',
+    'stubs/fdatasync-stub.c',
+    'stubs/fork-stub.c',
+    'stubs/fsync-stub.c',
+    'stubs/ftruncate-stub.c',
+    'stubs/get_current_dir_name-stub.c',
+    'stubs/getegid-stub.c',
+    'stubs/geteuid-stub.c',
+    'stubs/getgid-stub.c',
+    'stubs/getlogin-stub.c',
+    'stubs/getrusage-stub.c',
+    'stubs/getppid-stub.c',
+    'stubs/getpwent-stub.c',
+    'stubs/getpwnam-stub.c',
+    'stubs/getpwnam_r-stub.c',
+    'stubs/getpwuid-stub.c',
+    'stubs/getpwuid_r-stub.c',
+    'stubs/getuid-stub.c',
+    'stubs/getwd-stub.c',
+    'stubs/ioctl-stub.c',
+    'stubs/isatty-stub.c',
+    'stubs/issetugid-stub.c',
+    'stubs/kill-stub.c',
+    'stubs/lchown-stub.c',
+    'stubs/link-stub.c',
+    'stubs/llseek-stub.c',
+    'stubs/lstat-stub.c',
+    'stubs/pclose-stub.c',
+    'stubs/pipe-stub.c',
+    'stubs/popen-stub.c',
+    'stubs/pselect-stub.c',
+    'stubs/raise-stub.c',
+    'stubs/readlink-stub.c',
+    'stubs/remove-stub.c',
+    'stubs/rename-stub.c',
+    'stubs/select-stub.c',
+    'stubs/setegid-stub.c',
+    'stubs/seteuid-stub.c',
+    'stubs/setgid-stub.c',
+    'stubs/setpwent-stub.c',
+    'stubs/settimeofday-stub.c',
+    'stubs/setuid-stub.c',
+    'stubs/signal-stub.c',
+    'stubs/sigprocmask-stub.c',
+    'stubs/symlink-stub.c',
+    'stubs/system-stub.c',
+    'stubs/times-stub.c',
+    'stubs/tmpfile-stub.c',
+    'stubs/truncate-stub.c',
+    'stubs/ttyname-stub.c',
+    'stubs/ttyname_r-stub.c',
+    'stubs/umask-stub.c',
+    'stubs/utime-stub.c',
+    'stubs/utimes-stub.c',
+    'stubs/vfork-stub.c',
+    'stubs/wait-stub.c',
+    'stubs/waitpid-stub.c',
+]
+
 SRCS_NEWLIB_MISC = [
     'malloc.c',        # malloc wrapper
     'stacktrace.c',    # stack tracing for use with "-finstrument"
     'start.c',         # contains _start, preventing us from making this a .so
     'nacl_add_tp.c',
     'nacl_read_tp.c',
     'pthread_initialize_minimal.c',
     'pthread_stubs.c', # weak version of __pthread_initialize
     'tls.c',
 ]
 
 
 # used by both glibc and newlib
 SRCS_NACL_EXTENSIONS = [
     'gc_hooks.c',
     'nacl_irt.c',
     'nacl_tls_get.c',
     'nacl_tls_init.c',
     ]
 
 if env.Bit('nacl_glibc'):
   # For nacl-glibc, the standard interfaces are provided by glibc, so
   # we do not build them here.
   sources = SRCS_NACL_EXTENSIONS
 else:
-  sources = SRCS_NACL_EXTENSIONS + SRCS_NEWLIB_SYSCALL + SRCS_NEWLIB_MISC
+  sources = SRCS_NACL_EXTENSIONS + \

[Mark Seaborn, 2013/08/23 15:45:22]

Nit: Python style is to use ()s in preference to backslashes, i.e.
x = (a +
     b +
     c)

[Petr Hosek, 2013/08/23 21:35:07]

Fixed.

+            SRCS_NEWLIB_SYSCALL + \
+            SRCS_NEWLIB_STUBS + \
+            SRCS_NEWLIB_MISC
   if env.Bit('target_arm') and not env.Bit('bitcode'):
     sources.append('aeabi_read_tp.S')
 
 # Do not make a shared version of libnacl.
 libnacl = env.ComponentLibrary('libnacl', sources)
 
 env.AddLibraryToSdk(libnacl)
 header_install = env.AddHeaderToSdk(['nacl_startup.h', 'nacl_thread.h'])
 env.Requires('libnacl', header_install)
 
@@ skipping 49 matching lines @@
   # the libnacl_sys_private one.  Putting everything important into a
   # single .o file avoids this scenario.
   private_combine = [env.ComponentObject(module, '%s.c' % module)
                      for module in ['gc_hooks_private',
                                     'sys_private']]
   sys_private.append(env.Command('combined_private${OBJSUFFIX}',
                                  private_combine,
                                  '${LD} -relocatable -o ${TARGET} ${SOURCES}'))
 
 env.ComponentLibrary('libnacl_sys_private', sys_private)