src/untrusted/nosys/getegid.c - Issue 22923022: Make libnosys function stubs part of libnacl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/untrusted/nosys/getegid.c

Issue 22923022: Make libnosys function stubs part of libnacl (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Code review feedback Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 /*

2 * Copyright 2010 The Native Client Authors. All rights reserved.

3 * Use of this source code is governed by a BSD-style license that can

4 * be found in the LICENSE file.

5 */

6

7

8 /*

9 * Stub routine for `getegid' for porting support.

10 */

11

12 #include <unistd.h>

13 #include <sys/types.h>

14 #include <errno.h>

15

16 gid_t getegid(void) {

17 errno = ENOSYS;

18 return -1;

19 }

20

21 #include "native_client/src/untrusted/nosys/warning.h"

22 stub_warning(getegid);
Sam Clegg 2013/08/23 21:55:51 Can you remove all the stub warnings? Can you remove all the stub warnings? Petr Hosek 2013/08/23 22:34:56 They should be all gone already, do you seen any l Show quoted text On 2013/08/23 21:55:51, Sam Clegg wrote: > Can you remove all the stub warnings? They should be all gone already, do you seen any left? I have even removed the "warning.h" header file so I assume we would see build failure if there was some leftover. Sam Clegg 2013/08/23 22:36:33 Oops, my bad. Was reading the wrong side of the d Show quoted text On 2013/08/23 22:34:56, Petr Hosek wrote: > On 2013/08/23 21:55:51, Sam Clegg wrote: > > Can you remove all the stub warnings? > > They should be all gone already, do you seen any left? I have even removed the > "warning.h" header file so I assume we would see build failure if there was some > leftover. Oops, my bad. Was reading the wrong side of the diff.
OLD	NEW

« no previous file with comments | « src/untrusted/nosys/get_current_dir_name.c ('k') | src/untrusted/nosys/geteuid.c » ('j') | no next file with comments »