ppapi/proxy/pp_utils.h - Issue 22923014: TCPSockets are switched to the new Pepper proxy.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/proxy/pp_utils.h

Issue 22923014: TCPSockets are switched to the new Pepper proxy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Deleted logging. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc ('K') | « ppapi/proxy/interface_list.cc ('k') | ppapi/proxy/pp_utils.cc » ('j') | ppapi/proxy/tcp_socket_resource_base.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef PPAPI_PROXY_PP_UTILS_H_

	6 #define PPAPI_PROXY_PP_UTILS_H_

	7

	8 #include "base/basictypes.h"

	9

	10 namespace ppapi {

	11 namespace proxy {

	12

	13 // When \|private_api\| is true, coverts all network-related errors +;

	14 // PP_ERROR_NOACCESS to PP_ERROR_FAILED. Otherwise, returns \|pp_error\|

	15 // as is.

	16 int32_t ConvertPPError(int32_t pp_error, bool private_api);
	yzshen1 2013/08/19 19:07:07 Maybe we should merge this into ppapi/host/error_c Maybe we should merge this into ppapi/host/error_conversion.h? And we could call it ConvertNetworkAPIErrorForCompatibility() or something like that. ygorshenin1 2013/08/20 13:00:49 I've renamed this method, but not merged into ppap Show quoted text On 2013/08/19 19:07:07, yzshen1 wrote: > Maybe we should merge this into ppapi/host/error_conversion.h? > > And we could call it ConvertNetworkAPIErrorForCompatibility() or something like > that. I've renamed this method, but not merged into ppapi/host/error_conversion.h, because it requires in addition to ppapi_host an introduction of ppapi_host_untrusted target, as ConvertNetworkAPIErrorForCompatibility() is compiled for nacl. Yuzhu, what do you think? yzshen1 2013/08/20 22:39:58 I think you could move error_conversion.h/cc into Show quoted text On 2013/08/20 13:00:49, ygorshenin1 wrote: > On 2013/08/19 19:07:07, yzshen1 wrote: > > Maybe we should merge this into ppapi/host/error_conversion.h? > > > > And we could call it ConvertNetworkAPIErrorForCompatibility() or something > like > > that. > > I've renamed this method, but not merged into ppapi/host/error_conversion.h, > because > it requires in addition to ppapi_host an introduction of ppapi_host_untrusted > target, as ConvertNetworkAPIErrorForCompatibility() is compiled for nacl. Yuzhu, > what do you think? I think you could move error_conversion.h/cc into ppapi/proxy and then move this function into those files. ygorshenin1 2013/08/21 12:00:40 Done. Show quoted text On 2013/08/20 22:39:58, yzshen1 wrote: > On 2013/08/20 13:00:49, ygorshenin1 wrote: > > On 2013/08/19 19:07:07, yzshen1 wrote: > > > Maybe we should merge this into ppapi/host/error_conversion.h? > > > > > > And we could call it ConvertNetworkAPIErrorForCompatibility() or something > > like > > > that. > > > > I've renamed this method, but not merged into ppapi/host/error_conversion.h, > > because > > it requires in addition to ppapi_host an introduction of ppapi_host_untrusted > > target, as ConvertNetworkAPIErrorForCompatibility() is compiled for nacl. > Yuzhu, > > what do you think? > > I think you could move error_conversion.h/cc into ppapi/proxy and then move this > function into those files. > Done.
	17

	18 } // namespace proxy

	19 } // namespace ppapi

	20

	21 #endif // PPAPI_PROXY_PP_UTILS_H_

OLD	NEW