ppapi/proxy/pp_utils.h - Issue 22923014: TCPSockets are switched to the new Pepper proxy.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/proxy/pp_utils.h

Issue 22923014: TCPSockets are switched to the new Pepper proxy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Sync. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef PPAPI_PROXY_PP_UTILS_H_

	6 #define PPAPI_PROXY_PP_UTILS_H_

	7

	8 #include "base/basictypes.h"

	9

	10 namespace ppapi {

	11 namespace proxy {

	12 namespace pp_utils {
	yzshen1 2013/08/16 20:40:42 No need to add another layer of namespace. No need to add another layer of namespace. ygorshenin1 2013/08/19 14:33:35 Done. Show quoted text On 2013/08/16 20:40:42, yzshen1 wrote: > No need to add another layer of namespace. Done.
	13

	14 int32_t ConvertPPError(int32_t pp_error, bool private_api);
	yzshen1 2013/08/16 20:40:42 Both the file name and the method name are too bro Both the file name and the method name are too broad. And please add comments about what exactly this method does. ygorshenin1 2013/08/19 14:33:35 Done. Show quoted text On 2013/08/16 20:40:42, yzshen1 wrote: > Both the file name and the method name are too broad. > > And please add comments about what exactly this method does. Done.
	15

	16 } // namespace pp_utils

	17 } // namespace proxy

	18 } // namespace ppapi

	19

	20 #endif // PPAPI_PROXY_PP_UTILS_H_

OLD	NEW