[tracing] Add support for tab icons in <tr-ui-b-tab-view>

[tracing] Add support for tab icons in <tr-ui-b-tab-view>

I added a screenshot to the associated issue:
https://github.com/catapult-project/catapult/issues/2750#issuecomment-243797566

BUG=catapult:#2750

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bc8cdd0da02fbae27fcce58aba553cf1e54b38e0

[petrcermak, 2016-08-31 15:16:53]

Description was changed from

==========
[tracing] Add support for tab icons in <tr-ui-b-tab-view>

BUG=catapult:#2750
==========

to

==========
[tracing] Add support for tab icons in <tr-ui-b-tab-view>

I added a screenshot to the associated issue:
https://github.com/catapult-project/catapult/issues/2750#issuecomment-243797566

BUG=catapult:#2750
==========

[petrcermak, 2016-08-31 15:17:10]

petrcermak@chromium.org changed reviewers:
+ charliea@chromium.org

[petrcermak, 2016-08-31 15:17:10]

PTAL.

Thanks,
Petr

[charliea (OOO until 10-5), 2016-08-31 16:13:24]

lgtm w/ suggestion

https://codereview.chromium.org/2292293003/diff/1/tracing/tracing/ui/base/tab...
File tracing/tracing/ui/base/tab_view.html (right):

https://codereview.chromium.org/2292293003/diff/1/tracing/tracing/ui/base/tab...
tracing/tracing/ui/base/tab_view.html:83: <span
style$='[[computeTabIconStyle_(item.tabIcon)]]'>
It seems like it might be a good idea to make this more flexible, like:

<span style$='[[item.tabIcon.style]]'>

You may want your icon bolded and with a specific color, but someone else may
want the default color and unbolded. It seems like allowing arbitrary styles
might be the best way to support that.

[petrcermak, 2016-09-01 12:52:04]

https://codereview.chromium.org/2292293003/diff/1/tracing/tracing/ui/base/tab...
File tracing/tracing/ui/base/tab_view.html (right):

https://codereview.chromium.org/2292293003/diff/1/tracing/tracing/ui/base/tab...
tracing/tracing/ui/base/tab_view.html:83: <span
style$='[[computeTabIconStyle_(item.tabIcon)]]'>
On 2016/08/31 16:13:24, charliea wrote:
> It seems like it might be a good idea to make this more flexible, like:
> 
> <span style$='[[item.tabIcon.style]]'>
> 
> You may want your icon bolded and with a specific color, but someone else may
> want the default color and unbolded. It seems like allowing arbitrary styles
> might be the best way to support that.

Good point. I was a little worried about XSS
(https://www.owasp.org/index.php/XSS_Filter_Evasion_Cheat_Sheet#STYLE_tags_wit...),
but since (1) |item| is something that we create and (2) there are other places
that are equally vulnerable, I changed the patch.

[petrcermak, 2016-09-01 12:52:08]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-09-01 12:52:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
charliea@chromium.org
Link to the patchset: https://codereview.chromium.org/2292293003/#ps20001
(title: "Generalize to item.tabIcon.style")

[commit-bot: I haz the power, 2016-09-01 12:52:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 13:14:54]

Description was changed from

==========
[tracing] Add support for tab icons in <tr-ui-b-tab-view>

I added a screenshot to the associated issue:
https://github.com/catapult-project/catapult/issues/2750#issuecomment-243797566

BUG=catapult:#2750
==========

to

==========
[tracing] Add support for tab icons in <tr-ui-b-tab-view>

I added a screenshot to the associated issue:
https://github.com/catapult-project/catapult/issues/2750#issuecomment-243797566

BUG=catapult:#2750

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-09-01 13:14:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...