Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2292253002: Log the dtls handshake error. (Closed)

Created:
4 years, 3 months ago by zhihuang1
Modified:
4 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log the dtls handshake error. Add an uma counter to log how often dtls handshake fails because of incompatible cipher suites. Related CL: https://codereview.webrtc.org/2167363002/ BUG=webrtc:5959 Committed: https://crrev.com/47d02c08e678e4b2f478896693d24c2a0e64163f Cr-Commit-Position: refs/heads/master@{#415689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M content/renderer/media/rtc_peer_connection_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Zhi Huang
Hi, Please take a look on the changes. Thanks.
4 years, 3 months ago (2016-08-30 21:37:11 UTC) #8
Steven Holte
lgtm
4 years, 3 months ago (2016-08-30 22:12:06 UTC) #9
tommi (sloooow) - chröme
lgtm
4 years, 3 months ago (2016-08-31 18:20:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292253002/1
4 years, 3 months ago (2016-08-31 18:21:30 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 18:35:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47d02c08e678e4b2f478896693d24c2a0e64163f
Cr-Commit-Position: refs/heads/master@{#415689}

Powered by Google App Engine
This is Rietveld 408576698