Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2292223004: Parser::Declare follow-up to r38979. (Closed)

Created:
4 years, 3 months ago by marja
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Parser::Declare follow-up to r38979. BUG= Committed: https://crrev.com/d6f3fa67af7844698bc50526674fb7035d252eb7 Cr-Commit-Position: refs/heads/master@{#39053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/parsing/parser.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
marja
ptal
4 years, 3 months ago (2016-08-31 07:49:56 UTC) #2
adamk
lgtm
4 years, 3 months ago (2016-08-31 18:10:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292223004/1
4 years, 3 months ago (2016-08-31 18:11:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 18:58:26 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 18:59:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6f3fa67af7844698bc50526674fb7035d252eb7
Cr-Commit-Position: refs/heads/master@{#39053}

Powered by Google App Engine
This is Rietveld 408576698