Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2292203003: CallbackPromiseAdapter cleanup (Closed)

Created:
4 years, 3 months ago by yhirano
Modified:
4 years, 3 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CallbackPromiseAdapter cleanup Use std::move and delete unnecessary functions. BUG=None Committed: https://crrev.com/a724ffdcab0c1cac622382797ba23391fa09bcab Cr-Commit-Position: refs/heads/master@{#415661}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h View 1 5 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
yhirano
4 years, 3 months ago (2016-08-31 10:54:35 UTC) #9
haraken
LGTM
4 years, 3 months ago (2016-08-31 14:14:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292203003/20001
4 years, 3 months ago (2016-08-31 15:30:23 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 16:54:59 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 16:56:47 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a724ffdcab0c1cac622382797ba23391fa09bcab
Cr-Commit-Position: refs/heads/master@{#415661}

Powered by Google App Engine
This is Rietveld 408576698