Source/core/dom/ElementTraversal.h - Issue 229213002: Make HTMLCollection / NodeList backward traversal consistent with forward one

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ElementTraversal.h

Issue 229213002: Make HTMLCollection / NodeList backward traversal consistent with forward one (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/ElementTraversal.h

diff --git a/Source/core/dom/ElementTraversal.h b/Source/core/dom/ElementTraversal.h

index e6d7e924ed65168990537f355f2588727990de9f..e8241820b5e4abd39d4ff5530eba1fc289616f5b 100644

--- a/Source/core/dom/ElementTraversal.h

+++ b/Source/core/dom/ElementTraversal.h

@@ -119,7 +119,10 @@ template <>

template <class NodeType>

inline Element* Traversal<Element>::lastWithinTemplate(NodeType& current)

{

- return lastChildTemplate(current);

+ Node* node = NodeTraversal::lastWithin(current);

Inactive 2014/04/09 23:19:07 Also see that WebKit is doing the same thing that

+ while (node && !node->isElementNode())

+ node = NodeTraversal::previous(*node, &current);

+ return toElement(node);

}

template <>

« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/dom/LiveNodeList.h » ('j') | Source/core/dom/LiveNodeListBase.h » ('J')