Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: Source/core/dom/ChildNodeList.h

Issue 229213002: Make HTMLCollection / NodeList backward traversal consistent with forward one (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/ChildNodeList.cpp » ('j') | Source/core/dom/ElementTraversal.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2007 Apple Inc. All rights reserved.
6 * Copyright (C) 2014 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2014 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 30 matching lines...) Expand all
41 virtual ~ChildNodeList(); 41 virtual ~ChildNodeList();
42 42
43 // DOM API. 43 // DOM API.
44 virtual unsigned length() const OVERRIDE { return m_collectionIndexCache.nod eCount(*this); } 44 virtual unsigned length() const OVERRIDE { return m_collectionIndexCache.nod eCount(*this); }
45 virtual Node* item(unsigned index) const OVERRIDE { return m_collectionIndex Cache.nodeAt(*this, index); } 45 virtual Node* item(unsigned index) const OVERRIDE { return m_collectionIndex Cache.nodeAt(*this, index); }
46 46
47 // Non-DOM API. 47 // Non-DOM API.
48 void invalidateCache() { m_collectionIndexCache.invalidate(); } 48 void invalidateCache() { m_collectionIndexCache.invalidate(); }
49 ContainerNode& ownerNode() const { return *m_parent; } 49 ContainerNode& ownerNode() const { return *m_parent; }
50 50
51 ContainerNode& rootNode() const { return ownerNode(); }
52
51 // CollectionIndexCache API. 53 // CollectionIndexCache API.
52 ContainerNode& rootNode() const { return ownerNode(); }
53 bool canTraverseBackward() const { return true; } 54 bool canTraverseBackward() const { return true; }
54 Node* itemBefore(const Node* previousItem) const;
55 Node* traverseToFirstElement() const { return rootNode().firstChild(); } 55 Node* traverseToFirstElement() const { return rootNode().firstChild(); }
56 Node* traverseToLastElement() const { return rootNode().lastChild(); }
56 Node* traverseForwardToOffset(unsigned offset, Node& currentNode, unsigned& currentOffset) const; 57 Node* traverseForwardToOffset(unsigned offset, Node& currentNode, unsigned& currentOffset) const;
58 Node* traverseBackwardToOffset(unsigned offset, Node& currentNode, unsigned& currentOffset) const;
57 59
58 private: 60 private:
59 explicit ChildNodeList(ContainerNode& rootNode); 61 explicit ChildNodeList(ContainerNode& rootNode);
60 62
61 virtual bool isChildNodeList() const OVERRIDE { return true; } 63 virtual bool isChildNodeList() const OVERRIDE { return true; }
62 virtual Node* virtualOwnerNode() const OVERRIDE; 64 virtual Node* virtualOwnerNode() const OVERRIDE;
63 65
64 RefPtr<ContainerNode> m_parent; 66 RefPtr<ContainerNode> m_parent;
65 mutable CollectionIndexCache<ChildNodeList, Node> m_collectionIndexCache; 67 mutable CollectionIndexCache<ChildNodeList, Node> m_collectionIndexCache;
66 }; 68 };
67 69
68 DEFINE_TYPE_CASTS(ChildNodeList, NodeList, nodeList, nodeList->isChildNodeList() , nodeList.isChildNodeList()); 70 DEFINE_TYPE_CASTS(ChildNodeList, NodeList, nodeList, nodeList->isChildNodeList() , nodeList.isChildNodeList());
69 71
70 } // namespace WebCore 72 } // namespace WebCore
71 73
72 #endif // ChildNodeList_h 74 #endif // ChildNodeList_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/ChildNodeList.cpp » ('j') | Source/core/dom/ElementTraversal.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698