Fix CronetUrlRequestTest#testFailures flake

components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.os.ConditionVariable;
 import android.os.StrictMode;
 
 import static junit.framework.Assert.assertEquals;
@@ skipping 213 matching lines @@
             assertEquals("Exception received from UrlRequest.Callback", error.getMessage());
             assertNotNull(error.getCause());
             assertTrue(error.getCause() instanceof IllegalStateException);
             assertEquals("Listener Exception.", error.getCause().getMessage());
             assertFalse(error.immediatelyRetryable());
         }
 
         mOnErrorCalled = true;
         mError = error;
         openDone();
-        maybeThrowCancelOrPause(request);

[kapishnikov, 2016/08/30 16:15:57]

Why don't we update mResponseStep to ON_FAILED here? This would allow us to
potentially test the listener exceptions and cancelations that can happen in
onFailed() callback.

[xunjieli, 2016/08/30 17:05:43]

There is no enum ON_FAILED. We can certainly add one, but I don't think it's a
good idea to call maybeThrowCancelOrPause() with openDone().  If we want to test
failure or cancellation during onFailed, we need to do something with
openDone(). Otherwise, it's a bit confusing that the request is "done", but we
are still "canceling it or throwing an exception". WDYT?

     }
 
     @Override
     public void onCanceled(UrlRequest request, UrlResponseInfo info) {
         assertEquals(mExecutorThread, Thread.currentThread());
         assertTrue(request.isDone());
         // Should happen at most once for a single request.
         assertFalse(mOnCanceledCalled);
         assertFalse(mOnErrorCalled);
         assertNull(mError);
@@ skipping 46 matching lines @@
         };
         if (mFailureType == FailureType.CANCEL_ASYNC
                 || mFailureType == FailureType.CANCEL_ASYNC_WITHOUT_PAUSE) {
             getExecutor().execute(task);
         } else {
             task.run();
         }
         return mFailureType != FailureType.CANCEL_ASYNC_WITHOUT_PAUSE;
     }
 }