Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Unified Diff: net/quic/core/quic_connection.cc

Issue 2292083006: Include the two QUIC version sets in connection close details. (Closed)
Patch Set: Include the two QUIC version sets in connection close details. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_connection.cc
diff --git a/net/quic/core/quic_connection.cc b/net/quic/core/quic_connection.cc
index cb1f761c55cbf35b0bd5590353bf891430bb2098..734740cf849bdbb5d704c240fe8d5a5d5441326c 100644
--- a/net/quic/core/quic_connection.cc
+++ b/net/quic/core/quic_connection.cc
@@ -548,8 +548,13 @@ void QuicConnection::OnVersionNegotiationPacket(
}
if (!SelectMutualVersion(packet.versions)) {
- CloseConnection(QUIC_INVALID_VERSION, "No common version found.",
- ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET);
+ CloseConnection(
+ QUIC_INVALID_VERSION,
+ "No common version found. Supported versions: {" +
+ QuicVersionVectorToString(framer_.supported_versions()) +
+ "}, peer supported versions: {" +
+ QuicVersionVectorToString(packet.versions) + "}",
+ ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET);
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698