Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2292083004: Revert of Add tab persistence support for CustomTabs. (Closed)

Created:
4 years, 3 months ago by yhirano
Modified:
4 years, 3 months ago
Reviewers:
Ted C, Theresa, Yusuf, gone, nyquist
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add tab persistence support for CustomTabs. (patchset #6 id:100001 of https://codereview.chromium.org/2296833002/ ) Reason for revert: The added tests are failing. https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35991 Original issue's description: > Add tab persistence support for CustomTabs. > > BUG=606513 > > Committed: https://crrev.com/1bd10cbe206cb17700d56b92fdf07190437866ff > Cr-Commit-Position: refs/heads/master@{#415786} TBR=dfalcantara@chromium.org,yusufo@chromium.org,twellington@chromium.org,nyquist@chromium.org,tedchoc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=606513 Committed: https://crrev.com/e7f175a1a5ec859e918853143bfd37e29131e94c Cr-Commit-Position: refs/heads/master@{#415876}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -873 lines) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 2 chunks +6 lines, -2 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicy.java View 1 chunk +0 lines, -387 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistencePolicy.java View 1 chunk +6 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java View 4 chunks +5 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabbedModeTabPersistencePolicy.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java_sources.gni View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicyTest.java View 1 chunk +0 lines, -432 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
yhirano
Created Revert of Add tab persistence support for CustomTabs.
4 years, 3 months ago (2016-09-01 04:06:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292083004/1
4 years, 3 months ago (2016-09-01 04:06:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 04:07:36 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 04:35:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7f175a1a5ec859e918853143bfd37e29131e94c
Cr-Commit-Position: refs/heads/master@{#415876}

Powered by Google App Engine
This is Rietveld 408576698