Inject API key directly into snippets fetcher.

Inject API key directly into snippets fetcher.

With this, tests that involve a fetcher don't have to depend on
production API keys themselves.

Committed: https://crrev.com/225fdc67c3f27d729bd873c67cc48455b380a3e1
Cr-Commit-Position: refs/heads/master@{#418027}

[sfiera, 2016-08-30 17:44:58]

sfiera@chromium.org changed reviewers:
+ treib@chromium.org

[sfiera, 2016-08-30 17:44:58]

Removing the image URL tomorrow.

[Marc Treib, 2016-08-31 09:26:16]

lgtm

https://codereview.chromium.org/2292053004/diff/20001/chrome/browser/ntp_snip...
File chrome/browser/ntp_snippets/content_suggestions_service_factory.cc (right):

https://codereview.chromium.org/2292053004/diff/20001/chrome/browser/ntp_snip...
chrome/browser/ntp_snippets/content_suggestions_service_factory.cc:162: :
google_apis::GetNonStableAPIKey()),
You'll probably have to do the same thing in the iOS factory.

https://codereview.chromium.org/2292053004/diff/20001/components/ntp_snippets...
File components/ntp_snippets/ntp_snippets_fetcher.cc (left):

https://codereview.chromium.org/2292053004/diff/20001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_fetcher.cc:31: #include
"google_apis/google_api_keys.h"
Can we remove the google_apis/ dependency from components/ntp_snippets/BUILD.gn
and DEPS now?

https://codereview.chromium.org/2292053004/diff/20001/components/ntp_snippets...
File components/ntp_snippets/ntp_snippets_fetcher.h (right):

https://codereview.chromium.org/2292053004/diff/20001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_fetcher.h:234: // Flag for picking the
right (stable/non-stable) API key for Chrome Reader.
Please update the comment

[sfiera, 2016-08-31 10:08:45]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 10:09:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sfiera, 2016-08-31 10:09:16]

https://codereview.chromium.org/2292053004/diff/20001/chrome/browser/ntp_snip...
File chrome/browser/ntp_snippets/content_suggestions_service_factory.cc (right):

https://codereview.chromium.org/2292053004/diff/20001/chrome/browser/ntp_snip...
chrome/browser/ntp_snippets/content_suggestions_service_factory.cc:162: :
google_apis::GetNonStableAPIKey()),
On 2016/08/31 09:26:16, Marc Treib wrote:
> You'll probably have to do the same thing in the iOS factory.

Done, possibly.

https://codereview.chromium.org/2292053004/diff/20001/components/ntp_snippets...
File components/ntp_snippets/ntp_snippets_fetcher.cc (left):

https://codereview.chromium.org/2292053004/diff/20001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_fetcher.cc:31: #include
"google_apis/google_api_keys.h"
On 2016/08/31 09:26:16, Marc Treib wrote:
> Can we remove the google_apis/ dependency from
components/ntp_snippets/BUILD.gn
> and DEPS now?

Nope, we still use OAuth2TokenService.

https://codereview.chromium.org/2292053004/diff/20001/components/ntp_snippets...
File components/ntp_snippets/ntp_snippets_fetcher.h (right):

https://codereview.chromium.org/2292053004/diff/20001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_fetcher.h:234: // Flag for picking the
right (stable/non-stable) API key for Chrome Reader.
On 2016/08/31 09:26:16, Marc Treib wrote:
> Please update the comment

Done.

[commit-bot: I haz the power, 2016-08-31 11:03:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 11:03:32]

Dry run: This issue passed the CQ dry run.

[sfiera, 2016-08-31 13:17:25]

Description was changed from

==========
Inject API key directly into snippets fetcher.

With this, tests that involve a fetcher don't have to depend on
production API keys themselves.
==========

to

==========
Inject API key directly into snippets fetcher.

With this, tests that involve a fetcher don't have to depend on
production API keys themselves.
==========

[sfiera, 2016-08-31 13:17:25]

sfiera@chromium.org changed reviewers:
+ noyau@chromium.org

[sfiera, 2016-08-31 13:17:59]

Eric, this is just a small change to improve tests. PTAL.

[noyau (Ping after 24h), 2016-08-31 14:35:47]

ios lgtm.

[sfiera, 2016-09-12 19:28:35]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 19:29:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 20:13:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 20:13:28]

Dry run: This issue passed the CQ dry run.

[sfiera, 2016-09-12 20:15:22]

The CQ bit was checked by sfiera@chromium.org

[sfiera, 2016-09-12 20:15:23]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org,
noyau@chromium.org
Link to the patchset: https://codereview.chromium.org/2292053004/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-12 20:15:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 20:20:30]

Description was changed from

==========
Inject API key directly into snippets fetcher.

With this, tests that involve a fetcher don't have to depend on
production API keys themselves.
==========

to

==========
Inject API key directly into snippets fetcher.

With this, tests that involve a fetcher don't have to depend on
production API keys themselves.
==========

[commit-bot: I haz the power, 2016-09-12 20:20:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-12 20:24:03]

Description was changed from

==========
Inject API key directly into snippets fetcher.

With this, tests that involve a fetcher don't have to depend on
production API keys themselves.
==========

to

==========
Inject API key directly into snippets fetcher.

With this, tests that involve a fetcher don't have to depend on
production API keys themselves.

Committed: https://crrev.com/225fdc67c3f27d729bd873c67cc48455b380a3e1
Cr-Commit-Position: refs/heads/master@{#418027}
==========

[commit-bot: I haz the power, 2016-09-12 20:24:04]

Patchset 4 (id:??) landed as
https://crrev.com/225fdc67c3f27d729bd873c67cc48455b380a3e1
Cr-Commit-Position: refs/heads/master@{#418027}