Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Side by Side Diff: build_overrides/v8.gni

Issue 2292053003: [inspector] Build inspector under v8_enable_inspector build flag. (Closed)
Patch Set: owners Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | gypfiles/standalone.gypi » ('j') | src/v8.gyp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The V8 project authors. All rights reserved. 1 # Copyright 2015 The V8 project authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//build/config/v8_target_cpu.gni") 7 import("//build/config/v8_target_cpu.gni")
8 import("//gni/v8.gni") 8 import("//gni/v8.gni")
9 9
10 if (is_android) { 10 if (is_android) {
11 import("//build/config/android/config.gni") 11 import("//build/config/android/config.gni")
12 } 12 }
13 13
14 if (((v8_current_cpu == "x86" || 14 if (((v8_current_cpu == "x86" || v8_current_cpu == "x64" ||
15 v8_current_cpu == "x64" || 15 v8_current_cpu == "x87") && (is_linux || is_mac)) ||
16 v8_current_cpu=="x87") &&
17 (is_linux || is_mac)) ||
18 (v8_current_cpu == "ppc64" && is_linux)) { 16 (v8_current_cpu == "ppc64" && is_linux)) {
19 v8_enable_gdbjit_default = true 17 v8_enable_gdbjit_default = true
20 } 18 }
21 19
22 v8_imminent_deprecation_warnings_default = true 20 v8_imminent_deprecation_warnings_default = true
23 21
24 # Add simple extras solely for the purpose of the cctests. 22 # Add simple extras solely for the purpose of the cctests.
25 v8_extra_library_files = [ "//test/cctest/test-extra.js" ] 23 v8_extra_library_files = [ "//test/cctest/test-extra.js" ]
26 v8_experimental_extra_library_files = [ "//test/cctest/test-experimental-extra.j s" ] 24 v8_experimental_extra_library_files =
25 [ "//test/cctest/test-experimental-extra.js" ]
26
27 declare_args() {
28 # Enable inspector. See include/v8-inspector.h.
29 v8_enable_inspector = false
30 }
31
32 v8_enable_inspector_override = v8_enable_inspector
Michael Achenbach 2016/09/02 07:21:28 The last line should land in chromium's v8.gni fir
dgozman 2016/09/02 14:05:59 Sure! I want to get a review of this patch first t
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | gypfiles/standalone.gypi » ('j') | src/v8.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698