content/renderer/media/webrtc_audio_renderer.h - Issue 2292053002: Fix data race in WebRtcAudioRenderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_renderer.h

Issue 2292053002: Fix data race in WebRtcAudioRenderer. (Closed)

Patch Set: Accessing after the lock is released. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/webrtc_audio_renderer.h

diff --git a/content/renderer/media/webrtc_audio_renderer.h b/content/renderer/media/webrtc_audio_renderer.h

index 272eca08857b3fb8d4315e960bb9eff8dfac509c..3c4d22a11b96745c3995b960afa279a3b565ab03 100644

--- a/content/renderer/media/webrtc_audio_renderer.h

+++ b/content/renderer/media/webrtc_audio_renderer.h

@@ -213,7 +213,7 @@ class CONTENT_EXPORT WebRtcAudioRenderer

// Protects access to |state_|, |source_|, |audio_fifo_|,

// |audio_delay_milliseconds_|, |fifo_delay_milliseconds_|, |current_time_|,

- // |sink_params_| and |render_callback_count_|

+ // |sink_params_|, |render_callback_count_| and |max_render_time_|.

mutable base::Lock lock_;

// Ref count for the MediaPlayers which are playing audio.

« no previous file with comments | « no previous file | content/renderer/media/webrtc_audio_renderer.cc » ('j') | no next file with comments »