Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Issue 2292023003: Remove unused methods in CPDF_CMap (Closed)

Created:
4 years, 3 months ago by npm
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Clean up CPDF_CMap declaration - Removed unused methods - Friendship with CPDF_PathManager is not needed - Protected may be changed to private Committed: https://pdfium.googlesource.com/pdfium/+/77be04971c130cadbbdba04814f3d77ef25548bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M core/fpdfapi/fpdf_font/font_int.h View 1 chunk +1 line, -4 lines 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
npm
PTAL
4 years, 3 months ago (2016-08-30 21:55:58 UTC) #7
Lei Zhang
lgtm
4 years, 3 months ago (2016-08-30 22:56:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292023003/1
4 years, 3 months ago (2016-08-30 22:56:11 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 22:56:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/77be04971c130cadbbdba04814f3d77ef255...

Powered by Google App Engine
This is Rietveld 408576698