Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2291963002:
layout_test_helper crashed if there is no "1" color profile on Mac (Closed)
|
Created:
4 years, 3 months ago by yuki.sekiguchi Modified:
3 years, 8 months ago CC:
chromium-reviews, einbinder+watch-test-runner_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionlayout_test_helper crashed if there is no "1" color profile on Mac
InstallLayoutTestColorProfile() @ layout_test_helper_mac.mm
assumes that there is a color profile which id is "1". If there
is no such profile, it tries to retain user_color_profile_url
which is null and crashes.
It should get the id of the default color profile and use it to
to get the color profile URL.
BUG=642253
Patch Set 1 #
Messages
Total messages: 17 (7 generated)
The CQ bit was checked by yuki.sekiguchi@access-company.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: The author yuki.sekiguchi@access-company.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
yuki.sekiguchi@access-company.com changed reviewers: + jochen@chromium.org
Hi jochen, I'm not sure you're the correct person. Since you reviewed the following CL which added this file, I assigned you as reviewer. If you're not correct person, please let me know. https://chromium.googlesource.com/chromium/src/+/3611020a689b02cef892f10b25da... There is a CLA problem. Our company, ACCESS co ltd, sent CLA about 4 years ago. Then, I committed some CLs to Blink and Skia. What do I do to solve this problem?
jochen@chromium.org changed reviewers: + thakis@chromium.org
+thakis who knows more about Mac stuff. I can't find the CLA for your company. In fact, you need a CCLA (corporate CLA). Can you please work with your employer to resend the CCLA?
On 2016/08/30 11:49:12, jochen wrote: > +thakis who knows more about Mac stuff. > > I can't find the CLA for your company. In fact, you need a CCLA (corporate CLA). > Can you please work with your employer to resend the CCLA? I see. Thank you.
On 2016/08/30 11:52:30, yuki.sekiguchi wrote: > On 2016/08/30 11:49:12, jochen wrote: > > +thakis who knows more about Mac stuff. > > > > I can't find the CLA for your company. In fact, you need a CCLA (corporate > CLA). > > Can you please work with your employer to resend the CCLA? > > I see. Thank you. We sent CCLA to cla-submissions@google.com on 2013. I added our company name to AUTHORS in Skia: https://codereview.chromium.org/137923005/#msg8 https://skia.googlesource.com/skia/+/master/AUTHORS#14 I can forward the private mail with hcm@ for you. May I add our company name to AUTHORS in src/ as well?
On 2016/08/31 at 06:18:07, yuki.sekiguchi wrote: > On 2016/08/30 11:52:30, yuki.sekiguchi wrote: > > On 2016/08/30 11:49:12, jochen wrote: > > > +thakis who knows more about Mac stuff. > > > > > > I can't find the CLA for your company. In fact, you need a CCLA (corporate > > CLA). > > > Can you please work with your employer to resend the CCLA? > > > > I see. Thank you. > > We sent CCLA to cla-submissions@google.com on 2013. > I added our company name to AUTHORS in Skia: > https://codereview.chromium.org/137923005/#msg8 > https://skia.googlesource.com/skia/+/master/AUTHORS#14 > > I can forward the private mail with hcm@ for you. > > May I add our company name to AUTHORS in src/ as well? sorry, I can't find the CCLA in our database. I'm not in a position to accept a CCLA, so forwarding the communication to me won't help. Please ask your employer to resubmit the application
On 2016/08/31 14:35:44, jochen wrote: > sorry, I can't find the CCLA in our database. I'm not in a position to accept a > CCLA, so forwarding the communication to me won't help. > > Please ask your employer to resubmit the application I see. Thank you.
On 2016/09/01 at 01:27:48, yuki.sekiguchi wrote: > On 2016/08/31 14:35:44, jochen wrote: > > sorry, I can't find the CCLA in our database. I'm not in a position to accept a > > CCLA, so forwarding the communication to me won't help. > > > > Please ask your employer to resubmit the application > > I see. Thank you. I also filed an internal ticket to investigate this
On 2016/09/01 at 12:12:06, jochen wrote: > On 2016/09/01 at 01:27:48, yuki.sekiguchi wrote: > > On 2016/08/31 14:35:44, jochen wrote: > > > sorry, I can't find the CCLA in our database. I'm not in a position to accept a > > > CCLA, so forwarding the communication to me won't help. > > > > > > Please ask your employer to resubmit the application > > > > I see. Thank you. > > I also filed an internal ticket to investigate this I was told that your employer signed an earlier version of the CCLA, however, we need a current one, so please resubmit a new CCLA! thx -jochen
On 2016/09/02 09:09:50, jochen wrote: > On 2016/09/01 at 12:12:06, jochen wrote: > > On 2016/09/01 at 01:27:48, yuki.sekiguchi wrote: > > > On 2016/08/31 14:35:44, jochen wrote: > > > > sorry, I can't find the CCLA in our database. I'm not in a position to > accept a > > > > CCLA, so forwarding the communication to me won't help. > > > > > > > > Please ask your employer to resubmit the application > > > > > > I see. Thank you. > > > > I also filed an internal ticket to investigate this > > I was told that your employer signed an earlier version of the CCLA, however, we > need a current one, so please resubmit a new CCLA! > > thx > -jochen Sure. Thank you.
I can't reproduce this on ToT. Close this.
Description was changed from ========== layout_test_helper crashed if there is no "1" color profile on Mac InstallLayoutTestColorProfile() @ layout_test_helper_mac.mm assumes that there is a color profile which id is "1". If there is no such profile, it tries to retain user_color_profile_url which is null and crashes. It should get the id of the default color profile and use it to to get the color profile URL. BUG=642253 ========== to ========== layout_test_helper crashed if there is no "1" color profile on Mac InstallLayoutTestColorProfile() @ layout_test_helper_mac.mm assumes that there is a color profile which id is "1". If there is no such profile, it tries to retain user_color_profile_url which is null and crashes. It should get the id of the default color profile and use it to to get the color profile URL. BUG=642253 ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
