Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 2291933002: Do not call LayerAnimator::SetOpacity if the new value is same as the target value (Closed)

Created:
4 years, 3 months ago by oshima
Modified:
4 years, 3 months ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not call LayerAnimator::SetOpacity if the new value is same as the target value. I think this is safer to merge than https://codereview.chromium.org/2291923002/. I'll remove the check once the bug 64223 is fixed. BUG=642222 Committed: https://crrev.com/b0bddce1bad52c3efbe224c08a43fe02bf95cda3 Cr-Commit-Position: refs/heads/master@{#415341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M components/exo/shell_surface.cc View 2 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
oshima
4 years, 3 months ago (2016-08-30 17:32:17 UTC) #9
reveman
lgtm
4 years, 3 months ago (2016-08-30 17:41:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291933002/40001
4 years, 3 months ago (2016-08-30 17:42:59 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 3 months ago (2016-08-30 17:47:33 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 17:49:19 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0bddce1bad52c3efbe224c08a43fe02bf95cda3
Cr-Commit-Position: refs/heads/master@{#415341}

Powered by Google App Engine
This is Rietveld 408576698