Allow the user to cancel the capture region action, and show its active status in the tray.

Allow the user to cancel the capture region action, and show its active status in the tray.

BUG=639329
Committed: https://crrev.com/e4546d228f4c10f4e942e3692e46c3805ac68c22
Cr-Commit-Position: refs/heads/master@{#416334}

[jdufault, 2016-08-30 00:15:26]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[jdufault, 2016-08-30 00:15:37]

Description was changed from

==========
Allow the user to cancel the capture region action, and show it's active status
in the tray.

BUG=
==========

to

==========
Allow the user to cancel the capture region action, and show its active status
in the tray.

BUG=
==========

[commit-bot: I haz the power, 2016-08-30 02:14:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:42:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:42:59]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-08-30 18:06:35]

Description was changed from

==========
Allow the user to cancel the capture region action, and show its active status
in the tray.

BUG=
==========

to

==========
Allow the user to cancel the capture region action, and show its active status
in the tray.

BUG=642415
==========

[jdufault, 2016-08-30 18:08:29]

jdufault@chromium.org changed reviewers:
+ oshima@chromium.org

[jdufault, 2016-08-30 18:08:47]

oshima@, PTAL. Thanks!

[jdufault, 2016-08-30 21:07:19]

Description was changed from

==========
Allow the user to cancel the capture region action, and show its active status
in the tray.

BUG=642415
==========

to

==========
Allow the user to cancel the capture region action, and show its active status
in the tray.

BUG=639329
==========

[oshima, 2016-09-02 13:55:19]

lgtm with nits and q

https://codereview.chromium.org/2291913002/diff/1/ash/shell/shell_delegate_im...
File ash/shell/shell_delegate_impl.cc (right):

https://codereview.chromium.org/2291913002/diff/1/ash/shell/shell_delegate_im...
ash/shell/shell_delegate_impl.cc:101: void TakePartialScreenshot(const
base::Closure& done) override {}
nit: you may want to just run the callback for consistent behavior.

https://codereview.chromium.org/2291913002/diff/1/chrome/browser/ui/ash/palet...
File chrome/browser/ui/ash/palette_delegate_chromeos.cc (right):

https://codereview.chromium.org/2291913002/diff/1/chrome/browser/ui/ash/palet...
chrome/browser/ui/ash/palette_delegate_chromeos.cc:51: return
delegate_->HandleTakeWindowScreenshot(window);
just q: are you going to do the same for this mode?

https://codereview.chromium.org/2291913002/diff/1/chrome/browser/ui/ash/palet...
chrome/browser/ui/ash/palette_delegate_chromeos.cc:55: ash::ScreenshotDelegate*
delegate_;
nit: document ownership

[jdufault, 2016-09-02 19:46:32]

https://codereview.chromium.org/2291913002/diff/1/ash/shell/shell_delegate_im...
File ash/shell/shell_delegate_impl.cc (right):

https://codereview.chromium.org/2291913002/diff/1/ash/shell/shell_delegate_im...
ash/shell/shell_delegate_impl.cc:101: void TakePartialScreenshot(const
base::Closure& done) override {}
On 2016/09/02 13:55:19, oshima wrote:
> nit: you may want to just run the callback for consistent behavior.

Done.

https://codereview.chromium.org/2291913002/diff/1/chrome/browser/ui/ash/palet...
File chrome/browser/ui/ash/palette_delegate_chromeos.cc (right):

https://codereview.chromium.org/2291913002/diff/1/chrome/browser/ui/ash/palet...
chrome/browser/ui/ash/palette_delegate_chromeos.cc:51: return
delegate_->HandleTakeWindowScreenshot(window);
On 2016/09/02 13:55:19, oshima wrote:
> just q: are you going to do the same for this mode? 

Not planned right now, because that is an instantaneous action that does not
have user feedback.

https://codereview.chromium.org/2291913002/diff/1/chrome/browser/ui/ash/palet...
chrome/browser/ui/ash/palette_delegate_chromeos.cc:55: ash::ScreenshotDelegate*
delegate_;
On 2016/09/02 13:55:19, oshima wrote:
> nit: document ownership

Done.

[jdufault, 2016-09-02 19:46:35]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-09-02 19:46:36]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2291913002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-09-02 19:47:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 20:27:34]

Description was changed from

==========
Allow the user to cancel the capture region action, and show its active status
in the tray.

BUG=639329
==========

to

==========
Allow the user to cancel the capture region action, and show its active status
in the tray.

BUG=639329
==========

[commit-bot: I haz the power, 2016-09-02 20:27:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-02 20:30:17]

Description was changed from

==========
Allow the user to cancel the capture region action, and show its active status
in the tray.

BUG=639329
==========

to

==========
Allow the user to cancel the capture region action, and show its active status
in the tray.

BUG=639329

Committed: https://crrev.com/e4546d228f4c10f4e942e3692e46c3805ac68c22
Cr-Commit-Position: refs/heads/master@{#416334}
==========

[commit-bot: I haz the power, 2016-09-02 20:30:18]

Patchset 2 (id:??) landed as
https://crrev.com/e4546d228f4c10f4e942e3692e46c3805ac68c22
Cr-Commit-Position: refs/heads/master@{#416334}