Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2291903002: Flip Mac beta, stable configs to use GN. (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip Mac beta, stable configs to use GN. I forgot to change these two entries before the M54 branch, unfortunately, and this means that the M54 beta builder is still trying to use GYP. TBR=brettw@chromium.org NOTRY=true BUG=641634 Committed: https://crrev.com/7513f068d4def89f917d5971bfecd5933efd63c1 Cr-Commit-Position: refs/heads/master@{#415203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dirk Pranke
4 years, 3 months ago (2016-08-29 23:57:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291903002/1
4 years, 3 months ago (2016-08-30 02:14:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 06:10:22 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:12:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7513f068d4def89f917d5971bfecd5933efd63c1
Cr-Commit-Position: refs/heads/master@{#415203}

Powered by Google App Engine
This is Rietveld 408576698