Let Contraints Controll Mute/Unmute Audio Local Playback For Desktop Sharing

content/common/media/media_stream_options.h

Index: content/common/media/media_stream_options.h
diff --git a/content/common/media/media_stream_options.h b/content/common/media/media_stream_options.h
index 5eb060697d1ae2914e3076a0f0e751a17669c19d..f0aec2fde88ce261ac38bad2a7edad191fe957e6 100644
--- a/content/common/media/media_stream_options.h
+++ b/content/common/media/media_stream_options.h
@@ -57,6 +57,7 @@ struct CONTENT_EXPORT StreamControls {
   // Hotword functionality (chromeos only)
   // See crbug.com/564574 for discussion on possibly #ifdef'ing this out.
   bool hotword_enabled;  // kMediaStreamAudioHotword = "googHotword";

[Avi (use Gerrit), 2016/09/22 18:19:36]

What is this?!

I see the bug http://crbug.com/577627 about removing this layering violation.

You need to remove this layering violation.

[qiangchen, 2016/09/22 20:40:59]

But I am not familiar with this HotWord stuff, and by code searching I found it
is in use at [1]. So simply removing it would break something existing.

And I think this worth a separate CL to do it.

But similar qustion: Is this place appropriate to place "disable_local_echo"? Or
is it better if I put it as a field in |audio|?

[1]https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/media_stream_manager.cc?q=hotword_enabled&sq=package:chromium&l=152&dr=C

+  bool disable_local_echo;
 };
 
 // StreamDeviceInfo describes information about a device.