Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

Issue 2291893002: Let Contraints Controll Mute/Unmute Audio Local Playback For Desktop Sharing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp b/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
index 56c542d99bb0fa2d43524cb05623ef93976c2a78..ed30721e21f5a648f7fdee5b07348e6c9ecd7b02 100644
--- a/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
@@ -83,6 +83,7 @@ const char kMaxFrameRate[] = "maxFrameRate";
const char kMinFrameRate[] = "minFrameRate";
// From content/common/media/media_stream_options.cc
const char kMediaStreamSource[] = "chromeMediaSource";
+const char kMuteSourceAudio[] = "muteSourceAudio";
miu 2016/09/12 23:13:12 In answer to your question: Yes, this does need th
qiangchen 2016/09/13 21:46:57 Done.
const char kMediaStreamSourceId[] = "chromeMediaSourceId"; // mapped to deviceId
const char kMediaStreamSourceInfoId[] = "sourceId"; // mapped to deviceId
const char kMediaStreamRenderToAssociatedSink[] = "chromeRenderToAssociatedSink";
@@ -294,6 +295,8 @@ static void parseOldStyleNames(ExecutionContext* context, const Vector<NameValue
// represented as an enum, and cause type errors.
// https://crbug.com/576582
result.mediaStreamSource.setExact(constraint.m_value);
+ } else if (constraint.m_name.equals(kMuteSourceAudio)) {
+ result.muteSourceAudio.setExact(toBoolean(constraint.m_value));
} else if (constraint.m_name.equals(kMediaStreamSourceId)
|| constraint.m_name.equals(kMediaStreamSourceInfoId)) {
result.deviceId.setExact(constraint.m_value);

Powered by Google App Engine
This is Rietveld 408576698