Let Contraints Controll Mute/Unmute Audio Local Playback For Desktop Sharing

content/public/browser/desktop_media_id.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/desktop_media_id.h"
 
 #include <stdint.h>
 
 #include <vector>
 
@@ skipping 108 matching lines @@
          audio_share == other.audio_share;
 #endif
 }
 
 // static
 // Input string should in format:
 // for WebContents:
 // web-contents-media-stream://"render_process_id":"render_process_id"
 // for no aura screen and window: screen:"window_id" or window:"window_id"
 // for aura screen and window: screen:"window_id:aura_id" or
 //                         window:"window_id:aura_id".

[dcheng, 2016/09/16 22:36:04]

It doesn't have to be done in this CL... but can we use something more
structured than a std::string to transport this information? While I think the
current parsing code is safe, it'd make it even easier if I didn't have to read
any parsing code =)

[qiangchen, 2016/09/16 22:45:52]

Good suggestion. But I think one reason we use string is that when we first
wrote the media code, we support camera, microphone etc, and their device_ids
are strings we got from OS. Later when we add desktop capture functionality, we
made up some format to represent those IDs, to avoid changing all the parameter
signatures along the code paths.

 DesktopMediaID DesktopMediaID::Parse(const std::string& str) {
   // For WebContents type.
-  WebContentsMediaCaptureId web_id = WebContentsMediaCaptureId::Parse(str);
-  if (!web_id.is_null())
+  WebContentsMediaCaptureId web_id;
+  if (WebContentsMediaCaptureId::Parse(str, &web_id))
     return DesktopMediaID(TYPE_WEB_CONTENTS, 0, web_id);
 
   // For screen and window types.
   std::vector<std::string> parts = base::SplitString(
       str, ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
 
 #if defined(USE_AURA)
   if (parts.size() != 3)
     return DesktopMediaID();
 #else
@@ skipping 50 matching lines @@
 
 #if defined(USE_AURA)
   prefix.append(":");
   prefix.append(base::Int64ToString(aura_id));
 #endif  // defined(USE_AURA)
 
   return prefix;
 }
 
 }  // namespace content