Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2291883002: Fix missing style includes when inspector is used to force mobile. (Closed)

Created:
4 years, 3 months ago by DaleCurtis
Modified:
4 years, 3 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing style includes when inspector is used to force mobile. Without these fixes DCHECKs are triggered indicated that the resources are missing. Likely this also means the mobile view is not quite the same as if it was actually on mobile. See style sheets used in LayoutThemeMobile.cpp for details: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp BUG=none TEST=manual Committed: https://crrev.com/cf6c1dfce793ca8975647260c2be8a82187df54e Cr-Commit-Position: refs/heads/master@{#415187}

Patch Set 1 #

Patch Set 2 : Fix grd file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/public/blink_resources.grd View 1 1 chunk +5 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
DaleCurtis
4 years, 3 months ago (2016-08-29 22:37:26 UTC) #4
esprehn
lgtm, sucks because it makes the binary bigger for something that 99% of users will ...
4 years, 3 months ago (2016-08-29 23:08:58 UTC) #5
DaleCurtis
Yeah, had the same thought, luckily they're not very big, ~10kb: $ l themeChromiumAndroid.css mediaControlsAndroid.css ...
4 years, 3 months ago (2016-08-29 23:16:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291883002/20001
4 years, 3 months ago (2016-08-30 02:14:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 05:56:04 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:59:02 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf6c1dfce793ca8975647260c2be8a82187df54e
Cr-Commit-Position: refs/heads/master@{#415187}

Powered by Google App Engine
This is Rietveld 408576698