Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2291873002: Bind this in ng2 hack code (Closed)

Created:
4 years, 3 months ago by vsm
Modified:
4 years, 3 months ago
Reviewers:
Leaf, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M lib/src/compiler/code_generator.dart View 2 chunks +4 lines, -4 lines 2 comments Download

Messages

Total messages: 7 (3 generated)
vsm
https://codereview.chromium.org/2291873002/diff/1/lib/src/compiler/code_generator.dart File lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/2291873002/diff/1/lib/src/compiler/code_generator.dart#newcode3226 lib/src/compiler/code_generator.dart:3226: js.call('(#[(#[dart._extensionType]) ? dartx[#] : #]).bind(#)', FYI: this was the ...
4 years, 3 months ago (2016-08-29 22:01:04 UTC) #2
vsm
4 years, 3 months ago (2016-08-29 23:30:11 UTC) #4
Jennifer Messerly
lgtm
4 years, 3 months ago (2016-08-29 23:30:55 UTC) #5
vsm
4 years, 3 months ago (2016-08-29 23:41:37 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d6371ee44e8f119b847c1f4cc29957bff471057b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698