Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 2291813002: Skip the channel if there is no data. (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Skip the channel if there is no data. The JPX decoder needs to verify there is data associated with an image channel before access. This was already done in one side of the if() but seems to be missing from the other. This Cl updates the loop to check the existance of channel data and to continue iteration if none found. BUG=chromium:637232 Committed: https://pdfium.googlesource.com/pdfium/+/07f5fd57682700bcbba20f01d52a806676fd02ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M core/fxcodec/codec/fx_codec_jpx_opj.cpp View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-08-29 20:43:29 UTC) #3
Lei Zhang
lgtm
4 years, 3 months ago (2016-08-29 22:43:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291813002/1
4 years, 3 months ago (2016-08-29 22:43:14 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 22:43:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/07f5fd57682700bcbba20f01d52a806676fd...

Powered by Google App Engine
This is Rietveld 408576698