Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2291803002: Remove views.gypi, inline sources into GN files. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove views.gypi, inline sources into GN files. Previously the views unit tests duplicated sources between views_unittests and views_mus_unittests. This puts the sources in one target and shares the compiles between both test suites. Committed: https://crrev.com/a966841ca4a83201484dc55a79afff27ee681a83 Cr-Commit-Position: refs/heads/master@{#415402}

Patch Set 1 #

Patch Set 2 : Format #

Patch Set 3 : add mus #

Patch Set 4 : Remove some test from shared #

Patch Set 5 : Remove shared file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+701 lines, -1116 lines) Patch
M .gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/BUILD.gn View 1 2 3 4 10 chunks +699 lines, -34 lines 0 comments Download
M ui/views/mus/BUILD.gn View 5 chunks +2 lines, -25 lines 0 comments Download
D ui/views/views.gyp View 1 chunk +0 lines, -1055 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
brettw
4 years, 3 months ago (2016-08-29 20:34:25 UTC) #3
sky
Verified this does what we want for chromeos. For other platforms we may need to ...
4 years, 3 months ago (2016-08-29 21:09:46 UTC) #4
brettw
Remove some test from shared
4 years, 3 months ago (2016-08-29 21:57:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291803002/60001
4 years, 3 months ago (2016-08-30 02:14:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/288563) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-08-30 03:42:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291803002/60001
4 years, 3 months ago (2016-08-30 16:25:36 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/289076)
4 years, 3 months ago (2016-08-30 17:04:45 UTC) #17
brettw
Remove shared file
4 years, 3 months ago (2016-08-30 17:22:36 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291803002/80001
4 years, 3 months ago (2016-08-30 17:23:15 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-30 20:00:33 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 20:02:37 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a966841ca4a83201484dc55a79afff27ee681a83
Cr-Commit-Position: refs/heads/master@{#415402}

Powered by Google App Engine
This is Rietveld 408576698